Re: [PATCH v2] ag71xx: fix return value check in ag71xx_probe()

2019-07-18 Thread David Miller
From: Wei Yongjun Date: Fri, 19 Jul 2019 01:22:06 + > In case of error, the function of_get_mac_address() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") > Sig

[PATCH v2] ag71xx: fix return value check in ag71xx_probe()

2019-07-18 Thread Wei Yongjun
In case of error, the function of_get_mac_address() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") Signed-off-by: Wei Yongjun Reviewed-by: Oleksij Rempel --- v1 -> v2: fi