Re: [PATCH v2] FIRMWARE: bcm47xx_nvram: Replace mac address parsing

2018-03-08 Thread James Hogan
On Thu, Jan 18, 2018 at 03:40:57PM +0200, Andy Shevchenko wrote: > On Thu, 2017-12-21 at 17:42 +0100, Hauke Mehrtens wrote: > > > > On 12/21/2017 03:40 PM, Andy Shevchenko wrote: > > > Replace sscanf() with mac_pton(). > > > > > > Signed-off-by: Andy Shevchenko > > > > Acked-by: Hauke Mehrtens

Re: [PATCH v2] FIRMWARE: bcm47xx_nvram: Replace mac address parsing

2018-01-18 Thread Andy Shevchenko
On Thu, 2017-12-21 at 17:42 +0100, Hauke Mehrtens wrote: > > On 12/21/2017 03:40 PM, Andy Shevchenko wrote: > > Replace sscanf() with mac_pton(). > > > > Signed-off-by: Andy Shevchenko > > Acked-by: Hauke Mehrtens > > The patch looks good, but I haven't tested them on my devices. Any news on

Re: [PATCH v2] FIRMWARE: bcm47xx_nvram: Replace mac address parsing

2017-12-21 Thread Hauke Mehrtens
On 12/21/2017 03:40 PM, Andy Shevchenko wrote: > Replace sscanf() with mac_pton(). > > Signed-off-by: Andy Shevchenko Acked-by: Hauke Mehrtens The patch looks good, but I haven't tested them on my devices. > --- > - use negative condition to be consistent with the rest code > drivers/firmw

[PATCH v2] FIRMWARE: bcm47xx_nvram: Replace mac address parsing

2017-12-21 Thread Andy Shevchenko
Replace sscanf() with mac_pton(). Signed-off-by: Andy Shevchenko --- - use negative condition to be consistent with the rest code drivers/firmware/broadcom/Kconfig | 1 + drivers/firmware/broadcom/bcm47xx_sprom.c | 18 +++--- 2 files changed, 4 insertions(+), 15 deletions(-)