Re: [PATCH v2, resend] gianfar: don't duplicate gfar_error()

2007-02-17 Thread Jeff Garzik
Sergei Shtylyov wrote: It was hardly necessary to repeat most of the code from gfar_error() in gfar_interrupt(), especially having some inconsistencies between the two. So, make the gfar_interrupt() just call gfar_error(), and not acknowledge the interrupts itself as gfar_{receive/transmit/error}

Re: [PATCH v2, resend] gianfar: don't duplicate gfar_error()

2007-02-15 Thread Andy Fleming
On Feb 15, 2007, at 07:56, Sergei Shtylyov wrote: It was hardly necessary to repeat most of the code from gfar_error () in gfar_interrupt(), especially having some inconsistencies between the two. So, make the gfar_interrupt() just call gfar_error(), and not acknowledge the interrupts itse

[PATCH v2, resend] gianfar: don't duplicate gfar_error()

2007-02-15 Thread Sergei Shtylyov
It was hardly necessary to repeat most of the code from gfar_error() in gfar_interrupt(), especially having some inconsistencies between the two. So, make the gfar_interrupt() just call gfar_error(), and not acknowledge the interrupts itself as gfar_{receive/transmit/error}() do it anyway. While at