Re: [PATCH v10 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2020-11-19 Thread Andrew Lunn
On Fri, Nov 20, 2020 at 02:43:11AM +0100, Marek Behun wrote: > Hi Andrew, > > On Fri, 20 Nov 2020 02:29:06 +0100 > Andrew Lunn wrote: > > > > + if (speed >= 2500 && port > 0 && port < 9) > > > + return -EOPNOTSUPP; > > > > Maybe i'm missing something, but it looks like at this point y

Re: [PATCH v10 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2020-11-19 Thread Marek Behun
Hi Andrew, On Fri, 20 Nov 2020 02:29:06 +0100 Andrew Lunn wrote: > > + if (speed >= 2500 && port > 0 && port < 9) > > + return -EOPNOTSUPP; > > Maybe i'm missing something, but it looks like at this point you can > call > > return mv88e6xxx_port_set_speed_duplex(chip, port,

Re: [PATCH v10 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2020-11-19 Thread Andrew Lunn
> @@ -222,8 +231,8 @@ static int mv88e6xxx_port_set_speed_duplex(struct > mv88e6xxx_chip *chip, > return err; > > reg &= ~(MV88E6XXX_PORT_MAC_CTL_SPEED_MASK | > - MV88E6XXX_PORT_MAC_CTL_FORCE_DUPLEX | > - MV88E6XXX_PORT_MAC_CTL_DUPLEX_FULL); > +

[PATCH v10 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2020-11-19 Thread Pavana Sharma
The Marvell 88E6393X device is a single-chip integration of a 11-port Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers and three 10-Gigabit interfaces. This patch adds functionalities specific to mv88e6393x family (88E6393X, 88E6193X and 88E6191X) Co-developed-by: Ashkan