Re: [PATCH v10 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2021-01-20 Thread Jakub Kicinski
On Wed, 20 Jan 2021 20:30:14 +0100 Lukasz Stelmach wrote: > > You need to use 64 bit stats, like struct rtnl_link_stats64. > > On a 32bit system at 100Mbps ulong can wrap in minutes. > > > > Let me see. At first glance > > git grep -l ndo_get_stats\\\> drivers/net/ethernet/ | xargs grep -li >

Re: [PATCH v10 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2021-01-20 Thread Andrew Lunn
On Wed, Jan 20, 2021 at 08:30:14PM +0100, Lukasz Stelmach wrote: > It was <2021-01-15 pią 17:27>, when Jakub Kicinski wrote: > > On Wed, 13 Jan 2021 19:40:28 +0100 Łukasz Stelmach wrote: > >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be > >> connected to a CPU with a 8/16-bit b

Re: [PATCH v10 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2021-01-20 Thread Lukasz Stelmach
It was <2021-01-15 pią 17:27>, when Jakub Kicinski wrote: > On Wed, 13 Jan 2021 19:40:28 +0100 Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> >> The dri

Re: [PATCH v10 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2021-01-15 Thread Jakub Kicinski
On Wed, 13 Jan 2021 19:40:28 +0100 Łukasz Stelmach wrote: > ASIX AX88796[1] is a versatile ethernet adapter chip, that can be > connected to a CPU with a 8/16-bit bus or with an SPI. This driver > supports SPI connection. > > The driver has been ported from the vendor kernel for ARTIK5[2] > boards

[PATCH v10 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2021-01-13 Thread Łukasz Stelmach
ASIX AX88796[1] is a versatile ethernet adapter chip, that can be connected to a CPU with a 8/16-bit bus or with an SPI. This driver supports SPI connection. The driver has been ported from the vendor kernel for ARTIK5[2] boards. Several changes were made to adapt it to the current kernel which in