Re: [PATCH v1 net-next 1/5] drop_monitor: import netnamespace framework

2017-07-12 Thread Cong Wang
On Wed, Jul 12, 2017 at 10:08 AM, 张军伟(基础平台部) wrote: > about skb->sk > it is used as supplementary when skb->dev is empty,such as netlink message。 > > + if (skb->dev) > + net = dev_net(skb->dev); > + else if (skb->sk) > + net = sock_net(skb->sk); > + el

Re: [PATCH v1 net-next 1/5] drop_monitor: import netnamespace framework

2017-07-12 Thread Cong Wang
On Wed, Jul 12, 2017 at 6:37 AM, Neil Horman wrote: > On Wed, Jul 12, 2017 at 06:40:49PM +0800, martinbj2...@gmail.com wrote: >> The dropwatch is a very useful tool to diagnose network problem, >> which give us greate help. >> Dropwatch could not work under container(net namespace). >> It is a pit

Re: [PATCH v1 net-next 1/5] drop_monitor: import netnamespace framework

2017-07-12 Thread David Miller
You must provide a proper "[PATCH vx net-next 0/N]" header posting with a patch series, which describes at a high level what the patch series on a whole is doing, how it is doing it, and why it is doing it that way. Second, net-next is closed: http://vger.kernel.org/~davem/net-next.html

Re: [PATCH v1 net-next 1/5] drop_monitor: import netnamespace framework

2017-07-12 Thread Neil Horman
On Wed, Jul 12, 2017 at 06:40:49PM +0800, martinbj2...@gmail.com wrote: > From: martin Zhang > > This is a serial patch for drop monitor, in order to support net namespace. > > Import two struct to support net ns: > > 1. struct per_ns_dm_cb: > Just like its name, it is used in per net ns. >

[PATCH v1 net-next 1/5] drop_monitor: import netnamespace framework

2017-07-12 Thread martinbj2008
From: martin Zhang This is a serial patch for drop monitor, in order to support net namespace. Import two struct to support net ns: 1. struct per_ns_dm_cb: Just like its name, it is used in per net ns. In this patch it is empty, but in following patch, these field will be added. a. trace