Re: [PATCH v1 net-next 00/15] tc-taprio offload for SJA1105 DSA

2019-09-11 Thread Vladimir Oltean
Hi Vinicius, On 11/09/2019, Gomes, Vinicius wrote: > Hi Vladimir, > > [...] > >> >> I'll make sure this subtlety is more clearly formulated in the next >> version of the >> patch. >> > > Ack. > >> Actually let me ask you a few questions as well: >> >> - I'm trying to understand what is the correc

RE: [PATCH v1 net-next 00/15] tc-taprio offload for SJA1105 DSA

2019-09-10 Thread Gomes, Vinicius
Hi Vladimir, [...] > > I'll make sure this subtlety is more clearly formulated in the next version > of the > patch. > Ack. > Actually let me ask you a few questions as well: > > - I'm trying to understand what is the correct use of the tc-mqprio "queues" > argument. I've only tested it wit

Re: [PATCH v1 net-next 00/15] tc-taprio offload for SJA1105 DSA

2019-09-09 Thread Vladimir Oltean
Hi Andrew, Joergen, Richard, On 09/09/2019, Joergen Andreasen wrote: > The 09/08/2019 22:42, Andrew Lunn wrote: >> On Sun, Sep 08, 2019 at 12:07:27PM +0100, Vladimir Oltean wrote: >> > I think Richard has been there when the taprio, etf qdiscs, SO_TXTIME >> > were first defined and developed: >>

Re: [PATCH v1 net-next 00/15] tc-taprio offload for SJA1105 DSA

2019-09-09 Thread Vladimir Oltean
Hi Vinicius! On 10/09/2019, Gomes, Vinicius wrote: > Hi Vladimir, > >> This is a warning that I will toss this patch series if it receives no >> series review in >> the next couple of days. > > Sorry about the delay on reviewing this. On top on the usual business, some > changes to the > IT infra

RE: [PATCH v1 net-next 00/15] tc-taprio offload for SJA1105 DSA

2019-09-09 Thread Gomes, Vinicius
Hi Vladimir, > This is a warning that I will toss this patch series if it receives no series > review in > the next couple of days. Sorry about the delay on reviewing this. On top on the usual business, some changes to the IT infrastructure here have hit my email workflow pretty hard. I am tak

Re: [PATCH v1 net-next 00/15] tc-taprio offload for SJA1105 DSA

2019-09-09 Thread Joergen Andreasen
The 09/08/2019 22:42, Andrew Lunn wrote: > On Sun, Sep 08, 2019 at 12:07:27PM +0100, Vladimir Oltean wrote: > > I think Richard has been there when the taprio, etf qdiscs, SO_TXTIME > > were first defined and developed: > > https://patchwork.ozlabs.org/cover/808504/ > > I expect he is capable of de

Re: [PATCH v1 net-next 00/15] tc-taprio offload for SJA1105 DSA

2019-09-09 Thread Richard Cochran
On Sun, Sep 08, 2019 at 12:07:27PM +0100, Vladimir Oltean wrote: > I think Richard has been there when the taprio, etf qdiscs, SO_TXTIME > were first defined and developed: > https://patchwork.ozlabs.org/cover/808504/ > I expect he is capable of delivering a competent review of the entire > series,

Re: [PATCH v1 net-next 00/15] tc-taprio offload for SJA1105 DSA

2019-09-08 Thread Richard Cochran
On Sun, Sep 08, 2019 at 10:42:24PM +0200, Andrew Lunn wrote: > So if you are struggling to get something reviewed, make it more > appealing for the reviewer. Salami tactics. +1

Re: [PATCH v1 net-next 00/15] tc-taprio offload for SJA1105 DSA

2019-09-08 Thread Andrew Lunn
On Sun, Sep 08, 2019 at 12:07:27PM +0100, Vladimir Oltean wrote: > I think Richard has been there when the taprio, etf qdiscs, SO_TXTIME > were first defined and developed: > https://patchwork.ozlabs.org/cover/808504/ > I expect he is capable of delivering a competent review of the entire > series,

Re: [PATCH v1 net-next 00/15] tc-taprio offload for SJA1105 DSA

2019-09-08 Thread Vladimir Oltean
Hi Andrew, David, On Sep 7, 2019, at 3:46 PM, Andrew Lunn wrote: > > On Fri, Sep 06, 2019 at 02:54:03PM +0200, David Miller wrote: >> >> From: Vladimir Oltean >> Date: Mon, 2 Sep 2019 19:25:29 +0300 >> >>> >>> This is the first attempt to submit the tc-taprio offload model for >>> inclusion

Re: [PATCH v1 net-next 00/15] tc-taprio offload for SJA1105 DSA

2019-09-07 Thread Andrew Lunn
On Fri, Sep 06, 2019 at 02:54:03PM +0200, David Miller wrote: > From: Vladimir Oltean > Date: Mon, 2 Sep 2019 19:25:29 +0300 > > > This is the first attempt to submit the tc-taprio offload model for > > inclusion in the net tree. > > Someone really needs to review this. Hi Vladimir You might

Re: [PATCH v1 net-next 00/15] tc-taprio offload for SJA1105 DSA

2019-09-07 Thread David Miller
This is a warning that I will toss this patch series if it receives no series review in the next couple of days. Thank you.

Re: [PATCH v1 net-next 00/15] tc-taprio offload for SJA1105 DSA

2019-09-06 Thread David Miller
From: Vladimir Oltean Date: Mon, 2 Sep 2019 19:25:29 +0300 > This is the first attempt to submit the tc-taprio offload model for > inclusion in the net tree. Someone really needs to review this. I'm not applying this patch series until someone knowledgable in this area does some kind of review

[PATCH v1 net-next 00/15] tc-taprio offload for SJA1105 DSA

2019-09-02 Thread Vladimir Oltean
This is the first attempt to submit the tc-taprio offload model for inclusion in the net tree. Changes in this version: - Made "flags 1" and "flags 2" mutually exclusive in the taprio qdisc - Moved taprio_enable_offload and taprio_disable_offload out of atomic context - spin_lock_bh(qdisc_lock(s