Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-03-07 Thread Leon Romanovsky
On Wed, Mar 06, 2019 at 03:50:13PM -0600, Steve Wise wrote: > > On 3/4/2019 8:13 AM, Steve Wise wrote: > > Hey Leon, adding this to rd_recv_msg(): > > > > @@ -693,10 +693,28 @@ int rd_recv_msg(struct rd *rd, mnl_cb_t callback, void > > *data, unsigned int seq) > > ret = mnl_cb_run(b

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-03-06 Thread Steve Wise
On 3/4/2019 8:13 AM, Steve Wise wrote: > Hey Leon, adding this to rd_recv_msg(): > > @@ -693,10 +693,28 @@ int rd_recv_msg(struct rd *rd, mnl_cb_t callback, void > *data, unsigned int seq) > ret = mnl_cb_run(buf, ret, seq, portid, callback, data); > } while (ret > 0); > >

RE: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-03-04 Thread Steve Wise
> > > > > > On 2/23/2019 3:26 AM, Leon Romanovsky wrote: > > > > On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: > > > >> This function sends the constructed netlink message and then > > > >> receives the response, displaying any error text. > > > >> > > > >> Change 'rdma dev set' to

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-03-03 Thread Leon Romanovsky
ger.kernel.org; linux-r...@vger.kernel.org > > Subject: Re: [PATCH v1 iproute2-next 1/4] rdma: add helper > > rd_sendrecv_msg() > > > > > > On 2/23/2019 3:26 AM, Leon Romanovsky wrote: > > > On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: > &

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-28 Thread Steve Wise
On 2/28/2019 1:56 PM, Leon Romanovsky wrote: > On Thu, Feb 28, 2019 at 01:41:20PM -0600, Steve Wise wrote: >> On 2/23/2019 3:26 AM, Leon Romanovsky wrote: >>> On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: This function sends the constructed netlink message and then receive

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-28 Thread Leon Romanovsky
On Thu, Feb 28, 2019 at 01:41:20PM -0600, Steve Wise wrote: > > On 2/23/2019 3:26 AM, Leon Romanovsky wrote: > > On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: > >> This function sends the constructed netlink message and then > >> receives the response, displaying any error text. > >>

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-28 Thread Steve Wise
On 2/23/2019 3:26 AM, Leon Romanovsky wrote: > On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: >> This function sends the constructed netlink message and then >> receives the response, displaying any error text. >> >> Change 'rdma dev set' to use it. >> >> Signed-off-by: Steve Wise >

RE: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-27 Thread Steve Wise
> -Original Message- > From: Steve Wise > Sent: Tuesday, February 26, 2019 11:14 AM > To: Leon Romanovsky > Cc: dsah...@gmail.com; step...@networkplumber.org; > netdev@vger.kernel.org; linux-r...@vger.kernel.org > Subject: Re: [PATCH v1 iproute2-next

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-26 Thread David Ahern
On 2/26/19 10:19 AM, Steve Wise wrote: > >> Will we need this recv_msg if we implement >> extack support? > > I'm not sure how extack works.  Do you know? see devlink/mnlg.c mnlg_socket_open() { ... mnl_socket_setsockopt(nlg->nl, NETLINK_EXT_ACK, &one, sizeof(one)); ...

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-26 Thread Steve Wise
On 2/26/2019 1:16 PM, Leon Romanovsky wrote: > On Tue, Feb 26, 2019 at 11:19:12AM -0600, Steve Wise wrote: >> On 2/23/2019 3:31 AM, Leon Romanovsky wrote: >>> On Sat, Feb 23, 2019 at 11:26:15AM +0200, Leon Romanovsky wrote: On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: > Th

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-26 Thread Leon Romanovsky
On Tue, Feb 26, 2019 at 11:19:12AM -0600, Steve Wise wrote: > > On 2/23/2019 3:31 AM, Leon Romanovsky wrote: > > On Sat, Feb 23, 2019 at 11:26:15AM +0200, Leon Romanovsky wrote: > >> On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: > >>> This function sends the constructed netlink messag

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-26 Thread Steve Wise
On 2/23/2019 3:31 AM, Leon Romanovsky wrote: > On Sat, Feb 23, 2019 at 11:26:15AM +0200, Leon Romanovsky wrote: >> On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: >>> This function sends the constructed netlink message and then >>> receives the response, displaying any error text. >>>

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-26 Thread Steve Wise
On 2/23/2019 3:26 AM, Leon Romanovsky wrote: > On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: >> This function sends the constructed netlink message and then >> receives the response, displaying any error text. >> >> Change 'rdma dev set' to use it. >> >> Signed-off-by: Steve Wise >

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-23 Thread Leon Romanovsky
On Sat, Feb 23, 2019 at 11:26:15AM +0200, Leon Romanovsky wrote: > On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: > > This function sends the constructed netlink message and then > > receives the response, displaying any error text. > > > > Change 'rdma dev set' to use it. > > > > Sign

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-23 Thread Leon Romanovsky
On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: > This function sends the constructed netlink message and then > receives the response, displaying any error text. > > Change 'rdma dev set' to use it. > > Signed-off-by: Steve Wise > --- > rdma/dev.c | 2 +- > rdma/rdma.h | 1 + >

[PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-21 Thread Steve Wise
This function sends the constructed netlink message and then receives the response, displaying any error text. Change 'rdma dev set' to use it. Signed-off-by: Steve Wise --- rdma/dev.c | 2 +- rdma/rdma.h | 1 + rdma/utils.c | 21 + 3 files changed, 23 insertions(+), 1