Re: [PATCH v1 3/3] net: WireGuard secure network tunnel

2018-08-21 Thread Andrew Lunn
On Tue, Aug 21, 2018 at 04:59:52PM -0700, Jason A. Donenfeld wrote: > On Tue, Aug 21, 2018 at 4:54 PM David Miller wrote: > > > > From: "Jason A. Donenfeld" > > Date: Tue, 21 Aug 2018 16:41:50 -0700 > > > > > Is 100 in fact acceptable for new code? 120? 180? What's the > > > generally accepted l

Re: [PATCH v1 3/3] net: WireGuard secure network tunnel

2018-08-21 Thread Jason A. Donenfeld
On Tue, Aug 21, 2018 at 4:54 PM David Miller wrote: > > From: "Jason A. Donenfeld" > Date: Tue, 21 Aug 2018 16:41:50 -0700 > > > Is 100 in fact acceptable for new code? 120? 180? What's the > > generally accepted limit these days? > > Please keep it as close to 80 columns as possible. > > Line b

Re: [PATCH v1 3/3] net: WireGuard secure network tunnel

2018-08-21 Thread David Miller
From: "Jason A. Donenfeld" Date: Tue, 21 Aug 2018 16:41:50 -0700 > Is 100 in fact acceptable for new code? 120? 180? What's the > generally accepted limit these days? Please keep it as close to 80 columns as possible. Line breaks are not ugly, please embrace them :)

Re: [PATCH v1 3/3] net: WireGuard secure network tunnel

2018-08-21 Thread Jason A. Donenfeld
On Tue, Jul 31, 2018 at 1:22 PM Stephen Hemminger wrote: > > On Tue, 31 Jul 2018 21:11:02 +0200 > "Jason A. Donenfeld" wrote: > > > +static int walk_by_peer(struct allowedips_node __rcu *top, u8 bits, struct > > allowedips_cursor *cursor, struct wireguard_peer *peer, int (*func)(void > > *ctx,