Re: [PATCH v1 2/3] net/fsl: acpize xgmac_mdio

2020-06-19 Thread Calvin Johnson
On Wed, Jun 17, 2020 at 06:49:31PM +0100, Russell King - ARM Linux admin wrote: > On Wed, Jun 17, 2020 at 10:45:34PM +0530, Calvin Johnson wrote: > > From: Jeremy Linton > > > > Add ACPI support for xgmac MDIO bus registration while maintaining > > the existing DT support. > > > > The function m

Re: [PATCH v1 2/3] net/fsl: acpize xgmac_mdio

2020-06-19 Thread Russell King - ARM Linux admin
On Fri, Jun 19, 2020 at 08:29:27PM +0530, Calvin Johnson wrote: > On Wed, Jun 17, 2020 at 06:49:31PM +0100, Russell King - ARM Linux admin > wrote: > > On Wed, Jun 17, 2020 at 10:45:34PM +0530, Calvin Johnson wrote: > > > From: Jeremy Linton > > > > > > Add ACPI support for xgmac MDIO bus regist

Re: [PATCH v1 2/3] net/fsl: acpize xgmac_mdio

2020-06-18 Thread Andy Shevchenko
On Thu, Jun 18, 2020 at 8:43 PM Calvin Johnson wrote: > On Thu, Jun 18, 2020 at 07:00:20PM +0300, Andy Shevchenko wrote: > > On Thu, Jun 18, 2020 at 6:46 PM Jeremy Linton wrote: ... > > And here is the question, do we have (in form of email or other means) > > an official response from NXP abou

Re: [PATCH v1 2/3] net/fsl: acpize xgmac_mdio

2020-06-18 Thread Calvin Johnson
Hi, On Thu, Jun 18, 2020 at 07:00:20PM +0300, Andy Shevchenko wrote: > On Thu, Jun 18, 2020 at 6:46 PM Jeremy Linton wrote: > > On 6/17/20 12:34 PM, Andrew Lunn wrote: > > > On Wed, Jun 17, 2020 at 10:45:34PM +0530, Calvin Johnson wrote: > > >> From: Jeremy Linton > > > > > >> +static const stru

Re: [PATCH v1 2/3] net/fsl: acpize xgmac_mdio

2020-06-18 Thread Andy Shevchenko
On Thu, Jun 18, 2020 at 6:46 PM Jeremy Linton wrote: > On 6/17/20 12:34 PM, Andrew Lunn wrote: > > On Wed, Jun 17, 2020 at 10:45:34PM +0530, Calvin Johnson wrote: > >> From: Jeremy Linton > > > >> +static const struct acpi_device_id xgmac_acpi_match[] = { > >> +{ "NXP0006", (kernel_ulong_t)NU

Re: [PATCH v1 2/3] net/fsl: acpize xgmac_mdio

2020-06-18 Thread Jeremy Linton
Hi, On 6/17/20 12:34 PM, Andrew Lunn wrote: On Wed, Jun 17, 2020 at 10:45:34PM +0530, Calvin Johnson wrote: From: Jeremy Linton +static const struct acpi_device_id xgmac_acpi_match[] = { + { "NXP0006", (kernel_ulong_t)NULL }, Hi Jeremy What exactly does NXP0006 represent? An XGMAC

Re: [PATCH v1 2/3] net/fsl: acpize xgmac_mdio

2020-06-17 Thread Russell King - ARM Linux admin
On Wed, Jun 17, 2020 at 08:54:23PM +0300, Andy Shevchenko wrote: > On Wed, Jun 17, 2020 at 8:49 PM Russell King - ARM Linux admin > wrote: > > On Wed, Jun 17, 2020 at 10:45:34PM +0530, Calvin Johnson wrote: > > ... > > > > - ret = of_address_to_resource(np, 0, &res); > > > - if (ret) { >

Re: [PATCH v1 2/3] net/fsl: acpize xgmac_mdio

2020-06-17 Thread Andy Shevchenko
On Wed, Jun 17, 2020 at 8:49 PM Russell King - ARM Linux admin wrote: > On Wed, Jun 17, 2020 at 10:45:34PM +0530, Calvin Johnson wrote: ... > > - ret = of_address_to_resource(np, 0, &res); > > - if (ret) { > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + if (!res

Re: [PATCH v1 2/3] net/fsl: acpize xgmac_mdio

2020-06-17 Thread Russell King - ARM Linux admin
On Wed, Jun 17, 2020 at 10:45:34PM +0530, Calvin Johnson wrote: > From: Jeremy Linton > > Add ACPI support for xgmac MDIO bus registration while maintaining > the existing DT support. > > The function mdiobus_register() inside of_mdiobus_register(), brings > up all the PHYs on the mdio bus and a

Re: [PATCH v1 2/3] net/fsl: acpize xgmac_mdio

2020-06-17 Thread Andrew Lunn
On Wed, Jun 17, 2020 at 10:45:34PM +0530, Calvin Johnson wrote: > From: Jeremy Linton > +static const struct acpi_device_id xgmac_acpi_match[] = { > + { "NXP0006", (kernel_ulong_t)NULL }, Hi Jeremy What exactly does NXP0006 represent? An XGMAC MDIO bus master? Some NXP MDIO bus master? An X

Re: [PATCH v1 2/3] net/fsl: acpize xgmac_mdio

2020-06-17 Thread Andy Shevchenko
On Wed, Jun 17, 2020 at 8:16 PM Calvin Johnson wrote: > > From: Jeremy Linton > > Add ACPI support for xgmac MDIO bus registration while maintaining > the existing DT support. > > The function mdiobus_register() inside of_mdiobus_register(), brings > up all the PHYs on the mdio bus and attach the

[PATCH v1 2/3] net/fsl: acpize xgmac_mdio

2020-06-17 Thread Calvin Johnson
From: Jeremy Linton Add ACPI support for xgmac MDIO bus registration while maintaining the existing DT support. The function mdiobus_register() inside of_mdiobus_register(), brings up all the PHYs on the mdio bus and attach them to the bus. Signed-off-by: Jeremy Linton Signed-off-by: Calvin Jo