Re: [PATCH v1 1/3] bnx2x: Replace custom scnprintf()

2017-05-02 Thread David Miller
From: Andy Shevchenko Date: Tue, 2 May 2017 11:45:50 +0300 > On Sun, Apr 30, 2017 at 6:32 PM, David Miller wrote: >> It is an essential part of all patch series. > > I hope it doesn't apply for the single patch(es). No it does not.

Re: [PATCH v1 1/3] bnx2x: Replace custom scnprintf()

2017-05-02 Thread Andy Shevchenko
On Sun, Apr 30, 2017 at 6:32 PM, David Miller wrote: > From: Andy Shevchenko >>> Was there a cover-letter for your series? I've failed to find it. >> >> There was none since patches are quite straight forward. > > All patch series, regardless of how simple, should provide > a proper cover letter

Re: [PATCH v1 1/3] bnx2x: Replace custom scnprintf()

2017-04-30 Thread David Miller
From: Andy Shevchenko Date: Thu, 27 Apr 2017 16:36:59 +0300 > From: Andy Shevchenko > > Use scnprintf() when printing version instead of custom open coded variants. > > Signed-off-by: Andy Shevchenko Applied.

Re: [PATCH v1 1/3] bnx2x: Replace custom scnprintf()

2017-04-30 Thread David Miller
From: Andy Shevchenko Date: Sun, 30 Apr 2017 15:58:18 +0300 > On Sun, Apr 30, 2017 at 11:16 AM, Mintz, Yuval wrote: >>> From: Andy Shevchenko >>> >>> Use scnprintf() when printing version instead of custom open coded variants. >>> >>> Signed-off-by: Andy Shevchenko >> >> Hi Andy this seems cor

Re: [PATCH v1 1/3] bnx2x: Replace custom scnprintf()

2017-04-30 Thread Andy Shevchenko
On Sun, Apr 30, 2017 at 11:16 AM, Mintz, Yuval wrote: >> From: Andy Shevchenko >> >> Use scnprintf() when printing version instead of custom open coded variants. >> >> Signed-off-by: Andy Shevchenko > > Hi Andy this seems correct. > Was there a cover-letter for your series? I've failed to find i

RE: [PATCH v1 1/3] bnx2x: Replace custom scnprintf()

2017-04-30 Thread Mintz, Yuval
> From: Andy Shevchenko > > Use scnprintf() when printing version instead of custom open coded variants. > > Signed-off-by: Andy Shevchenko Hi Andy this seems correct. Was there a cover-letter for your series? I've failed to find it. [I was mostly interested in your motivation for this kind of

[PATCH v1 1/3] bnx2x: Replace custom scnprintf()

2017-04-27 Thread Andy Shevchenko
From: Andy Shevchenko Use scnprintf() when printing version instead of custom open coded variants. Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 79 +++- 1 file changed, 9 insertions(+), 70 deletions(-) diff --git a/drivers/net/ether