Re: [PATCH v1 1/2] pptp: Use macro and sizeof instead of literal number

2016-08-19 Thread Philp Prindeville
Inline... On 08/17/2016 10:47 PM, f...@48lvckh6395k16k5.yundunddos.com wrote: From: Gao Feng Use existing macros like PPP_ADDRESS, SC_COMP_PROT and sizeof fixed variables instead of original literal number to enhance readbility. BTW, the original pptp_rcv uses literal number "12" as the param

Re: [PATCH v1 1/2] pptp: Use macro and sizeof instead of literal number

2016-08-19 Thread David Miller
From: f...@ikuai8.com Date: Thu, 18 Aug 2016 12:47:34 +0800 > @@ -54,6 +54,8 @@ static struct proto pptp_sk_proto __read_mostly; > static const struct ppp_channel_ops pptp_chan_ops; > static const struct proto_ops pptp_ops; > > +static const u8 fixed_ppphdr[2] = {PPP_ALLSTATIONS, PPP_UI}; > +

[PATCH v1 1/2] pptp: Use macro and sizeof instead of literal number

2016-08-17 Thread fgao
From: Gao Feng Use existing macros like PPP_ADDRESS, SC_COMP_PROT and sizeof fixed variables instead of original literal number to enhance readbility. BTW, the original pptp_rcv uses literal number "12" as the param of pskb_may_pull. Actually the "12" is less than the size of struct pptp_gre_hea