Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Andrew Lunn
On Tue, Feb 06, 2018 at 11:58:17AM -0500, Sven Van Asbroeck wrote: > On Tue, Feb 6, 2018 at 11:50 AM, Andrew Lunn wrote: > > And a DSA driver does not need to be complex. You can start simple, > > and add more features later. > > I see. Would it be possible/practical to start with just phy_read/w

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Sven Van Asbroeck
Andrew and Florian, thanks for your input. On Tue, Feb 6, 2018 at 12:05 PM, Andrew Lunn wrote: > I would NACK sysfs bin file. Do it right, or don't do it at all. On Tue, Feb 6, 2018 at 12:47 PM, Florian Fainelli wrote: > Sven, there is a standard ethtool register dump interface that can be > us

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Florian Fainelli
On 02/06/2018 09:05 AM, Andrew Lunn wrote: > On Tue, Feb 06, 2018 at 11:58:17AM -0500, Sven Van Asbroeck wrote: >> On Tue, Feb 6, 2018 at 11:50 AM, Andrew Lunn wrote: >>> And a DSA driver does not need to be complex. You can start simple, >>> and add more features later. >> >> I see. Would it be p

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Andrew Lunn
On Tue, Feb 06, 2018 at 11:41:14AM -0500, Sven Van Asbroeck wrote: > On Tue, Feb 6, 2018 at 11:14 AM, Andrew Lunn wrote: > > Rather than invest time in this driver, it would be better to look > > into writing a DSA driver. > > Thank you Andrew. I know little of DSA, but at first sight it appears

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Sven Van Asbroeck
On Tue, Feb 6, 2018 at 11:50 AM, Andrew Lunn wrote: > And a DSA driver does not need to be complex. You can start simple, > and add more features later. I see. Would it be possible/practical to start with just phy_read/write, port_enable/disable in dsa_switch_ops ? And just add a sysfs bin file f

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Sven Van Asbroeck
On Tue, Feb 6, 2018 at 11:14 AM, Andrew Lunn wrote: > Rather than invest time in this driver, it would be better to look > into writing a DSA driver. Thank you Andrew. I know little of DSA, but at first sight it appears to be a _very_ complicated beast for a switch PHY which only needs a few stat

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Andrew Lunn
On Tue, Feb 06, 2018 at 10:13:55AM -0500, Sven Van Asbroeck wrote: > v1: > starting point. > is there a way to test-run this on supported devices that I don't > have physical access to - (ks8995, ksz8864) ? > > Sven Van Asbroeck (1): > spi_ks8995: use regmap to access c

[PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Sven Van Asbroeck
v1: starting point. is there a way to test-run this on supported devices that I don't have physical access to - (ks8995, ksz8864) ? Sven Van Asbroeck (1): spi_ks8995: use regmap to access chip registers. drivers/net/phy/spi_ks8995.c | 163 +--