Re: [PATCH v1] Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE() macro

2017-12-13 Thread Marcel Holtmann
Hi Andy, > This macro deduplicates a lot of similar code across the hci_debugfs.c > module. Targeting to be moved to seq_file.h eventually. > > Signed-off-by: Andy Shevchenko > --- > net/bluetooth/hci_debugfs.c | 184 +--- > 1 file changed, 18 insertions(+)

Re: [PATCH v1] Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE() macro

2017-11-23 Thread Andy Shevchenko
On Wed, 2017-11-22 at 14:13 -0800, Randy Dunlap wrote: > On 11/22/2017 02:04 PM, Randy Dunlap wrote: > > On 11/22/2017 01:15 PM, Andy Shevchenko wrote: > > > This macro deduplicates a lot of similar code across the > > > hci_debugfs.c > > > module. Targeting to be moved to seq_file.h eventually >

Re: [PATCH v1] Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE() macro

2017-11-22 Thread Randy Dunlap
On 11/22/2017 02:04 PM, Randy Dunlap wrote: > On 11/22/2017 01:15 PM, Andy Shevchenko wrote: >> This macro deduplicates a lot of similar code across the hci_debugfs.c >> module. Targeting to be moved to seq_file.h eventually. >> >> Signed-off-by: Andy Shevchenko >> --- >> net/bluetooth/hci_debugf

Re: [PATCH v1] Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE() macro

2017-11-22 Thread Randy Dunlap
On 11/22/2017 01:15 PM, Andy Shevchenko wrote: > This macro deduplicates a lot of similar code across the hci_debugfs.c > module. Targeting to be moved to seq_file.h eventually. > > Signed-off-by: Andy Shevchenko > --- > net/bluetooth/hci_debugfs.c | 184 > +-

[PATCH v1] Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE() macro

2017-11-22 Thread Andy Shevchenko
This macro deduplicates a lot of similar code across the hci_debugfs.c module. Targeting to be moved to seq_file.h eventually. Signed-off-by: Andy Shevchenko --- net/bluetooth/hci_debugfs.c | 184 +--- 1 file changed, 18 insertions(+), 166 deletions(-) di