Re: [PATCH v05 21/72] include/uapi/linux/if_pppox.h: include linux/if.h

2016-08-22 Thread Mikko Rapeli
On Mon, Aug 22, 2016 at 12:37:45PM -0700, Stephen Hemminger wrote: > On Mon, 22 Aug 2016 20:32:38 +0200 > Mikko Rapeli wrote: > > > Fixes userspace compilation error: > > > > error: ‘IFNAMSIZ’ undeclared here (not in a function) > > > > Signed-off-by: Mikko Rapeli > > --- > > include/uapi/lin

Re: [PATCH v05 21/72] include/uapi/linux/if_pppox.h: include linux/if.h

2016-08-22 Thread David Miller
From: Mikko Rapeli Date: Mon, 22 Aug 2016 20:32:38 +0200 > Fixes userspace compilation error: > > error: ‘IFNAMSIZ’ undeclared here (not in a function) > > Signed-off-by: Mikko Rapeli Applied.

Re: [PATCH v05 21/72] include/uapi/linux/if_pppox.h: include linux/if.h

2016-08-22 Thread David Miller
From: Stephen Hemminger Date: Mon, 22 Aug 2016 12:37:45 -0700 > It seems your goal is that every include file should be standalone, > i.e it must include every definition it uses. I think this is absolutely mandatory Stephen. If you include x.h it should just work if you use the interfaces x.h

Re: [PATCH v05 21/72] include/uapi/linux/if_pppox.h: include linux/if.h

2016-08-22 Thread Stephen Hemminger
On Mon, 22 Aug 2016 20:32:38 +0200 Mikko Rapeli wrote: > Fixes userspace compilation error: > > error: ‘IFNAMSIZ’ undeclared here (not in a function) > > Signed-off-by: Mikko Rapeli > --- > include/uapi/linux/if_pppox.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/uapi/li

[PATCH v05 21/72] include/uapi/linux/if_pppox.h: include linux/if.h

2016-08-22 Thread Mikko Rapeli
Fixes userspace compilation error: error: ‘IFNAMSIZ’ undeclared here (not in a function) Signed-off-by: Mikko Rapeli --- include/uapi/linux/if_pppox.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/if_pppox.h b/include/uapi/linux/if_pppox.h index e128769..473c3c4 100644