Re: [PATCH target-pending] iscsi-target: make sure to wake up sleeping login worker

2018-01-23 Thread Nicholas A. Bellinger
Hey Florian & Co, On Fri, 2018-01-19 at 18:26 +0100, Florian Westphal wrote: > Eric Dumazet wrote: > > On Fri, 2018-01-19 at 14:36 +0100, Florian Westphal wrote: > > > diff --git a/drivers/target/iscsi/iscsi_target_nego.c > > > b/drivers/target/iscsi/iscsi_target_nego.c > > > index b686e2ce9c0e.

Re: [PATCH target-pending] iscsi-target: make sure to wake up sleeping login worker

2018-01-19 Thread Florian Westphal
Eric Dumazet wrote: > On Fri, 2018-01-19 at 14:36 +0100, Florian Westphal wrote: > > diff --git a/drivers/target/iscsi/iscsi_target_nego.c > > b/drivers/target/iscsi/iscsi_target_nego.c > > index b686e2ce9c0e..3723f8f419aa 100644 > > --- a/drivers/target/iscsi/iscsi_target_nego.c > > +++ b/driver

Re: [PATCH target-pending] iscsi-target: make sure to wake up sleeping login worker

2018-01-19 Thread Eric Dumazet
On Fri, 2018-01-19 at 14:36 +0100, Florian Westphal wrote: > Mike Christie reports: > Starting in 4.14 iscsi logins will fail around 50% of the time. > > Problem appears to be that iscsi_target_sk_data_ready() callback may > return without doing anything in case it finds the login work queue > i

[PATCH target-pending] iscsi-target: make sure to wake up sleeping login worker

2018-01-19 Thread Florian Westphal
Mike Christie reports: Starting in 4.14 iscsi logins will fail around 50% of the time. Problem appears to be that iscsi_target_sk_data_ready() callback may return without doing anything in case it finds the login work queue is still blocked in sock_recvmsg(). Nicholas Bellinger says: It would