Re: [PATCH rfc 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address

2017-02-16 Thread Sagi Grimberg
Yea, I wanted to get all the rpc_pton/rpc_ntop (which handle both ipv4 and ipv6 with scopes) converted to use a common helper. RPC is dealing with universal addresses, which are not quite the same as IP presentation addresses. The port number is expressed as: hi8.lo8 I noticed that, that'

Re: [PATCH rfc 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address

2017-02-16 Thread Chuck Lever
> On Feb 16, 2017, at 12:53 PM, Sagi Grimberg wrote: > > Hey Chuck, > >>> As a side-effect, this set adds ipv6 support for nvme over fabrics. >>> I also converted iscsi target and plan to convert nfs/cifs next but >>> wanted to get some feedback before doing that. >> >> At least NFS/RDMA alrea

Re: [PATCH rfc 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address

2017-02-16 Thread Sagi Grimberg
Hey Chuck, As a side-effect, this set adds ipv6 support for nvme over fabrics. I also converted iscsi target and plan to convert nfs/cifs next but wanted to get some feedback before doing that. At least NFS/RDMA already supports IPv6. You might not need many changes there, but I'll hold off on

Re: [PATCH rfc 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address

2017-02-16 Thread Chuck Lever
> On Feb 16, 2017, at 12:43 PM, Sagi Grimberg wrote: > > We have some places in the stack that support ipv4 and ipv6. In > some cases the user configuration does not reveal which > address family is given and needs to be parsed from the input string. > > Given that the user-input varies between

[PATCH rfc 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address

2017-02-16 Thread Sagi Grimberg
We have some places in the stack that support ipv4 and ipv6. In some cases the user configuration does not reveal which address family is given and needs to be parsed from the input string. Given that the user-input varies between subsystems, some processing is required from the call-site to separ