Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-12 Thread Miklos Szeredi
> This looks good, patch applied and I'll get this into the > 2.6.23 merge window. > > Once this sits around for a while and we feel super-confident > with it we can consider a backport into -stable. OK. Thanks for the review. Miklos - To unsubscribe from this list: send the line "unsubscribe n

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-11 Thread David Miller
From: Miklos Szeredi <[EMAIL PROTECTED]> Date: Wed, 04 Jul 2007 11:49:41 +0200 > Throw out the old mark & sweep garbage collector and put in a > refcounting cycle detecting one. > > The old one had a race with recvmsg, that resulted in false positives > and hence data loss. The old algorithm ope

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-11 Thread Miklos Szeredi
> > Dave, I really appreciate the work you do. Please forgive my > > impatience. > > No problem. > > Your patch is first in line for me to review tomorrow ok? Great, thanks. Miklos - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED]

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-11 Thread David Miller
From: Miklos Szeredi <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 09:04:10 +0200 > Dave, I really appreciate the work you do. Please forgive my > impatience. No problem. Your patch is first in line for me to review tomorrow ok? - To unsubscribe from this list: send the line "unsubscribe netdev" i

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-11 Thread Miklos Szeredi
> > This may seem low priority and irrelevant, but it _is_ a bug, and it's > > affecting a real world application. So please take that into > > consideration. > > I'm not the only person who hasn't reviewed your latest patch yet. > > You may want to consider that this might have something to do

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-10 Thread David Miller
From: Miklos Szeredi <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 08:41:30 +0200 > This may seem low priority and irrelevant, but it _is_ a bug, and it's > affecting a real world application. So please take that into > consideration. I'm not the only person who hasn't reviewed your latest patch ye

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-10 Thread Miklos Szeredi
> > But myself, nor any other developers, are going to review your work > > any faster if you do things like try to slip things in behind the > > maintainer's back as you attempted to do yesterday by asking Andrew to > > put your AF_UNIX garbage collector rewrite directly into his -mm tree. > > mm

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-10 Thread Andrew Morton
On Tue, 10 Jul 2007 22:12:24 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > But myself, nor any other developers, are going to review your work > any faster if you do things like try to slip things in behind the > maintainer's back as you attempted to do yesterday by asking Andrew to > put

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-10 Thread David Miller
Just to make it clear Miklos. I have seen your patch as has everyone else. But myself, nor any other developers, are going to review your work any faster if you do things like try to slip things in behind the maintainer's back as you attempted to do yesterday by asking Andrew to put your AF_UNIX

[PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-04 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Throw out the old mark & sweep garbage collector and put in a refcounting cycle detecting one. The old one had a race with recvmsg, that resulted in false positives and hence data loss. The old algorithm operated on all unix sockets in the system, so any