Re: [PATCH pci] pci: Add helper function to set VPD size

2016-04-15 Thread Bjorn Helgaas
[+cc Hannes, Ariel, LKML] On Thu, Apr 14, 2016 at 11:42:05PM +0530, Hariprasad Shenai wrote: > commit 104daa71b396 ("PCI: Determine actual VPD size on first access") > introduced a regression in cxgb4 driver and used to fail in pci probe. > > The problem is stemming from the fact that the Chelsio

Re: [PATCH pci] pci: Add helper function to set VPD size

2016-04-15 Thread Casey Leedom
| From: Steve Wise | Sent: Friday, April 15, 2016 9:12 AM | | On 4/14/2016 1:35 PM, Steve Wise wrote: | >> The fix is to add a PCI helper function to set the VPD size, so the | >> driver can expicitly set the exact size of the VPD. | >> | >> Fixes commit 104daa71b396 ("PCI: Determine actual VPD si

Re: [PATCH pci] pci: Add helper function to set VPD size

2016-04-15 Thread Bjorn Helgaas
On Fri, Apr 15, 2016 at 11:12:02AM -0500, Steve Wise wrote: > On 4/14/2016 1:35 PM, Steve Wise wrote: > >>The fix is to add a PCI helper function to set the VPD size, so the > >>driver can expicitly set the exact size of the VPD. > >> > >>Fixes commit 104daa71b396 ("PCI: Determine actual VPD size o

Re: [PATCH pci] pci: Add helper function to set VPD size

2016-04-15 Thread Steve Wise
On 4/14/2016 1:35 PM, Steve Wise wrote: The fix is to add a PCI helper function to set the VPD size, so the driver can expicitly set the exact size of the VPD. Fixes commit 104daa71b396 ("PCI: Determine actual VPD size on first access") Signed-off-by: Casey Leedom Signed-off-by: Hariprasad She

RE: [PATCH pci] pci: Add helper function to set VPD size

2016-04-14 Thread Steve Wise
> The fix is to add a PCI helper function to set the VPD size, so the > driver can expicitly set the exact size of the VPD. > > Fixes commit 104daa71b396 ("PCI: Determine actual VPD size on first access") > > Signed-off-by: Casey Leedom > Signed-off-by: Hariprasad Shenai Looks good! Tested-

[PATCH pci] pci: Add helper function to set VPD size

2016-04-14 Thread Hariprasad Shenai
commit 104daa71b396 ("PCI: Determine actual VPD size on first access") introduced a regression in cxgb4 driver and used to fail in pci probe. The problem is stemming from the fact that the Chelsio adapters actually have two VPD structures stored in the VPD. An abbreviated on at Offset 0x0 and the