Re: [PATCH nf-next v9 8/8] openvswitch: Interface with NAT.

2016-03-10 Thread Jarno Rajahalme
Thanks for the reviews Joe! Comments below. > On Mar 9, 2016, at 7:47 PM, Joe Stringer wrote: > > Hi Jarno, > > Thanks for working on this. Mostly just a few style things around #ifdefs > below. > > On 9 March 2016 at 15:10, Jarno Rajahalme wrote: >> Extend OVS conntrack interface to cover N

Re: [PATCH nf-next v9 8/8] openvswitch: Interface with NAT.

2016-03-10 Thread Jarno Rajahalme
> On Mar 10, 2016, at 4:00 AM, Thomas Graf wrote: > > On 03/09/16 at 07:47pm, Joe Stringer wrote: >> On 9 March 2016 at 15:10, Jarno Rajahalme wrote: >>> Extend OVS conntrack interface to cover NAT. New nested >>> OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. >>> A bar

Re: [PATCH nf-next v9 8/8] openvswitch: Interface with NAT.

2016-03-10 Thread Thomas Graf
On 03/09/16 at 07:47pm, Joe Stringer wrote: > On 9 March 2016 at 15:10, Jarno Rajahalme wrote: > > Extend OVS conntrack interface to cover NAT. New nested > > OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. > > A bare OVS_CT_ATTR_NAT only mangles existing and expected conne

Re: [PATCH nf-next v9 8/8] openvswitch: Interface with NAT.

2016-03-09 Thread Joe Stringer
Hi Jarno, Thanks for working on this. Mostly just a few style things around #ifdefs below. On 9 March 2016 at 15:10, Jarno Rajahalme wrote: > Extend OVS conntrack interface to cover NAT. New nested > OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. > A bare OVS_CT_ATTR_NAT

[PATCH nf-next v9 8/8] openvswitch: Interface with NAT.

2016-03-09 Thread Jarno Rajahalme
Extend OVS conntrack interface to cover NAT. New nested OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. A bare OVS_CT_ATTR_NAT only mangles existing and expected connections. If OVS_NAT_ATTR_SRC or OVS_NAT_ATTR_DST is included within the nested attributes, new (non-committed