Re: [PATCH nf-next v4 1/5] net: sched: Micro-optimize egress handling

2021-01-30 Thread Lukas Wunner
On Tue, Jan 26, 2021 at 11:58:17AM +0300, Dan Carpenter wrote: > On Mon, Jan 25, 2021 at 11:39:08AM -0800, Jakub Kicinski wrote: > > On Sun, 24 Jan 2021 11:33:01 +0100 Lukas Wunner wrote: > > > On Fri, Jan 22, 2021 at 10:40:05AM +0100, Eric Dumazet wrote: > > > > On Fri, Jan 22, 2021 at 9:55 AM Luk

Re: [PATCH nf-next v4 1/5] net: sched: Micro-optimize egress handling

2021-01-26 Thread Dan Carpenter
On Mon, Jan 25, 2021 at 11:39:08AM -0800, Jakub Kicinski wrote: > On Sun, 24 Jan 2021 11:33:01 +0100 Lukas Wunner wrote: > > On Fri, Jan 22, 2021 at 10:40:05AM +0100, Eric Dumazet wrote: > > > On Fri, Jan 22, 2021 at 9:55 AM Lukas Wunner wrote: > > > > sch_handle_egress() returns either the skb

Re: [PATCH nf-next v4 1/5] net: sched: Micro-optimize egress handling

2021-01-25 Thread Jakub Kicinski
On Sun, 24 Jan 2021 11:33:01 +0100 Lukas Wunner wrote: > On Fri, Jan 22, 2021 at 10:40:05AM +0100, Eric Dumazet wrote: > > On Fri, Jan 22, 2021 at 9:55 AM Lukas Wunner wrote: > > > sch_handle_egress() returns either the skb or NULL to signal to its > > > caller __dev_queue_xmit() whether a packe

Re: [PATCH nf-next v4 1/5] net: sched: Micro-optimize egress handling

2021-01-24 Thread Lukas Wunner
On Sat, Jan 23, 2021 at 07:26:24PM -0800, Jakub Kicinski wrote: > On Fri, 22 Jan 2021 09:47:01 +0100 Lukas Wunner wrote: > > sch_handle_egress() returns either the skb or NULL to signal to its > > caller __dev_queue_xmit() whether a packet should continue to be > > processed. > > > > The skb is al

Re: [PATCH nf-next v4 1/5] net: sched: Micro-optimize egress handling

2021-01-24 Thread Lukas Wunner
On Fri, Jan 22, 2021 at 10:40:05AM +0100, Eric Dumazet wrote: > On Fri, Jan 22, 2021 at 9:55 AM Lukas Wunner wrote: > > sch_handle_egress() returns either the skb or NULL to signal to its > > caller __dev_queue_xmit() whether a packet should continue to be > > processed. > > > > The skb is always

Re: [PATCH nf-next v4 1/5] net: sched: Micro-optimize egress handling

2021-01-23 Thread Jakub Kicinski
On Fri, 22 Jan 2021 09:47:01 +0100 Lukas Wunner wrote: > sch_handle_egress() returns either the skb or NULL to signal to its > caller __dev_queue_xmit() whether a packet should continue to be > processed. > > The skb is always non-NULL, otherwise __dev_queue_xmit() would hit a > NULL pointer deref

[PATCH nf-next v4 1/5] net: sched: Micro-optimize egress handling

2021-01-22 Thread Lukas Wunner
sch_handle_egress() returns either the skb or NULL to signal to its caller __dev_queue_xmit() whether a packet should continue to be processed. The skb is always non-NULL, otherwise __dev_queue_xmit() would hit a NULL pointer deref right at its top. But the compiler doesn't know that. So if sch_