Re: [PATCH next 0/3] blackhole device to invalidate dst

2019-06-24 Thread महेश बंडेवार
On Mon, Jun 24, 2019 at 9:00 PM Michael Chan wrote: > > On Fri, Jun 21, 2019 at 5:45 PM Mahesh Bandewar wrote: > > > Well, I'm not a TCP expert and though we have experienced > > these corner cases in our environment, I could not reproduce > > this case reliably in my test setup to try this fix m

Re: [PATCH next 0/3] blackhole device to invalidate dst

2019-06-24 Thread Michael Chan
On Fri, Jun 21, 2019 at 5:45 PM Mahesh Bandewar wrote: > Well, I'm not a TCP expert and though we have experienced > these corner cases in our environment, I could not reproduce > this case reliably in my test setup to try this fix myself. > However, Michael Chan had a setup > where these fixes

Re: [PATCH next 0/3] blackhole device to invalidate dst

2019-06-23 Thread महेश बंडेवार
On Sat, Jun 22, 2019 at 8:35 AM David Ahern wrote: > > On 6/21/19 6:45 PM, Mahesh Bandewar wrote: > > When we invalidate dst or mark it "dead", we assign 'lo' to > > dst->dev. First of all this assignment is racy and more over, > > it has MTU implications. > > > > The standard dev MTU is 1500 whil

Re: [PATCH next 0/3] blackhole device to invalidate dst

2019-06-22 Thread David Ahern
On 6/21/19 6:45 PM, Mahesh Bandewar wrote: > When we invalidate dst or mark it "dead", we assign 'lo' to > dst->dev. First of all this assignment is racy and more over, > it has MTU implications. > > The standard dev MTU is 1500 while the Loopback MTU is 64k. TCP > code when dereferencing the dst

[PATCH next 0/3] blackhole device to invalidate dst

2019-06-21 Thread Mahesh Bandewar
When we invalidate dst or mark it "dead", we assign 'lo' to dst->dev. First of all this assignment is racy and more over, it has MTU implications. The standard dev MTU is 1500 while the Loopback MTU is 64k. TCP code when dereferencing the dst don't check if the dst is valid or not. TCP when derefe