Re: [PATCH next] arp: avoid sending ucast probes to 00:00:00:00:00:00

2016-12-01 Thread Eric Dumazet
On Thu, 2016-12-01 at 15:47 -0800, Mahesh Bandewar (महेश बंडेवार) wrote: > [...] > >> @@ -371,10 +372,12 @@ static void arp_solicit(struct neighbour *neigh, > >> struct sk_buff *skb) > >> > >> probes -= NEIGH_VAR(neigh->parms, UCAST_PROBES); > >> if (probes < 0) { > >> + me

Re: [PATCH next] arp: avoid sending ucast probes to 00:00:00:00:00:00

2016-12-01 Thread महेश बंडेवार
[...] >> @@ -371,10 +372,12 @@ static void arp_solicit(struct neighbour *neigh, >> struct sk_buff *skb) >> >> probes -= NEIGH_VAR(neigh->parms, UCAST_PROBES); >> if (probes < 0) { >> + memset(&null_dev_hw_addr, 0, dev->addr_len); >> if (!(neigh->nud_state & NU

Re: [PATCH next] arp: avoid sending ucast probes to 00:00:00:00:00:00

2016-12-01 Thread Eric Dumazet
On Thu, 2016-12-01 at 14:56 -0800, Mahesh Bandewar wrote: > From: Mahesh Bandewar > > If initial broadcast probe(s) is/are lost, the neigh entry wont have > valid address of the neighbour. In a situation like this, the fall > back should be to send a broadcast probe, however the code logic > cont

[PATCH next] arp: avoid sending ucast probes to 00:00:00:00:00:00

2016-12-01 Thread Mahesh Bandewar
From: Mahesh Bandewar If initial broadcast probe(s) is/are lost, the neigh entry wont have valid address of the neighbour. In a situation like this, the fall back should be to send a broadcast probe, however the code logic continues sending ucast probes to 00:00:00:00:00:00. The default value of