Re: [PATCH netdev-2.6 02/11] ixgb: Fix the use of dprintk rather than printk

2006-03-03 Thread Jeff Garzik
Jesse Brandeburg wrote: I don't think this is cheating at all. It allows us to use the DPRINTK macro before everything is all set up to print "eth0: blah" and instead it prints "Bus:dev:Fn: blah" which is pretty useful, IMO. If you have any ideas about how to do this better we're open to them

Re: [PATCH netdev-2.6 02/11] ixgb: Fix the use of dprintk rather than printk

2006-03-03 Thread Jesse Brandeburg
On Fri, 3 Mar 2006, Jeff Garzik wrote: Jeff Kirsher wrote: +#define DEFAULT_DEBUG_LEVEL_SHIFT 3 +static int debug = DEFAULT_DEBUG_LEVEL_SHIFT; +module_param(debug, int, 0); +MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)"); @@ -386,6 +394,7 @@ ixgb_probe(struct pci_dev *pdev,

Re: [PATCH netdev-2.6 02/11] ixgb: Fix the use of dprintk rather than printk

2006-03-03 Thread Jeff Garzik
Jeff Kirsher wrote: +#define DEFAULT_DEBUG_LEVEL_SHIFT 3 +static int debug = DEFAULT_DEBUG_LEVEL_SHIFT; +module_param(debug, int, 0); +MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)"); @@ -386,6 +394,7 @@ ixgb_probe(struct pci_dev *pdev, adapter->netdev = netdev; ad

[PATCH netdev-2.6 02/11] ixgb: Fix the use of dprintk rather than printk

2006-03-02 Thread Jeff Kirsher
- use DPRINTK and msglvl instead of printk - allow ethtool control of msglvl Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb.h |8 +- drivers/net/ixgb/ixg