From: Christoph Hellwig <[EMAIL PROTECTED]>
Subject: Re: [PATCH netdev-2.6] sky2: new experimental Marvell Yukon2 driver
Date: Wed, 17 Aug 2005 20:27:40 +0100
> On Wed, Aug 17, 2005 at 03:25:30PM -0400, Jeff Garzik wrote:
> > >>It's just highly irregular to use pci_unmap
On Wed, Aug 17, 2005 at 03:25:30PM -0400, Jeff Garzik wrote:
> >>It's just highly irregular to use pci_unmap_xxx functions immediately
> >>after calling a pci_map_xxx function.
> >
> >
> >Did you know that pci_unmap_addr_set() is a macro that hides the fact
> >that some arch need iommu but for man
Stephen Hemminger wrote:
Jeff Garzik <[EMAIL PROTECTED]> wrote:
| > +
| > +paddr = pci_map_single(sky2->hw->pdev, re->skb->data,
| > + rx_buf_size, PCI_DMA_FROMDEVICE);
| > +
| > +pci_unmap_len_set(re, maplen, rx_buf_size);
|
On Wed, 17 Aug 2005 14:30:31 -0400
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Stephen Hemminger wrote:
> > |
> > | Applied to 'sky2' branch of netdev-2.6.git. Let me know when the RX
> > | hangs are fixed, and we can push upstream.
> >
> > Okay. Most all of your comments are straightforward
> >
Stephen Hemminger wrote:
|
| Applied to 'sky2' branch of netdev-2.6.git. Let me know when the RX
| hangs are fixed, and we can push upstream.
Okay. Most all of your comments are straightforward
and fixes will be in the next version, but some need
a little more discussion...
|
| > +static v
|
| Applied to 'sky2' branch of netdev-2.6.git. Let me know when the RX
| hangs are fixed, and we can push upstream.
Okay. Most all of your comments are straightforward
and fixes will be in the next version, but some need
a little more discussion...
|
| > +static void gm_phy_write(struct sky
Stephen Hemminger wrote:
New driver for the Marvell Yukon2 Gigabit Ethernet chipset.
This driver is based on the skge driver, but using the logic
from the SysKonnect version of the sk98lin driver.
It should support all the Yukon2 chipsets that are available
in many current Intel and AMD motherboa
