Re: [PATCH net v5] net: xdp: account for layer 3 packets in generic skb handler

2020-08-14 Thread Jason A. Donenfeld
On 8/14/20, David Miller wrote: > From: "Jason A. Donenfeld" > Date: Fri, 14 Aug 2020 09:30:48 +0200 > >> @@ -4676,6 +4688,7 @@ static u32 netif_receive_generic_xdp(struct sk_buff >> *skb, >> (orig_bcast != is_multicast_ether_addr_64bits(eth->h_dest))) { >> __skb_push(skb, E

Re: [PATCH net v5] net: xdp: account for layer 3 packets in generic skb handler

2020-08-14 Thread David Miller
From: "Jason A. Donenfeld" Date: Fri, 14 Aug 2020 09:30:48 +0200 > @@ -4676,6 +4688,7 @@ static u32 netif_receive_generic_xdp(struct sk_buff > *skb, > (orig_bcast != is_multicast_ether_addr_64bits(eth->h_dest))) { > __skb_push(skb, ETH_HLEN); > skb->protocol

[PATCH net v5] net: xdp: account for layer 3 packets in generic skb handler

2020-08-14 Thread Jason A. Donenfeld
A user reported that packets from wireguard were possibly ignored by XDP [1]. Another user reported that modifying packets from layer 3 interfaces results in impossible to diagnose drops. Apparently, the generic skb xdp handler path seems to assume that packets will always have an ethernet header,