On Wed, 14 Feb 2018, David Miller wrote:
> > Have you considered that implementing the ethtool hooks in the core
> > driver might allow removal of all 8390 driver 'msg_enable' module
> > parameters and msglevel ethtool hooks added by c45f812f0280, excepting
> > those in the core driver? But eve
From: Finn Thain
Date: Thu, 15 Feb 2018 09:11:13 +1100 (AEDT)
> On Tue, 13 Feb 2018, David Miller wrote:
>
>> > I think you have overlooked those modules which offer no way to set
>> > p->msg_enable, i.e. ax88796, axnet_cs, etherh, hydra, mac8390,
>> > mcf8390, pcnet_cs and zorro8390.
>>
>> T
On Tue, 13 Feb 2018, David Miller wrote:
> > I think you have overlooked those modules which offer no way to set
> > p->msg_enable, i.e. ax88796, axnet_cs, etherh, hydra, mac8390,
> > mcf8390, pcnet_cs and zorro8390.
>
> Then that's a bug, we have a very simple easy to implement interface for
From: Finn Thain
Date: Tue, 13 Feb 2018 16:03:09 +1100 (AEDT)
> I think you have overlooked those modules which offer no way to set
> p->msg_enable, i.e. ax88796, axnet_cs, etherh, hydra, mac8390, mcf8390,
> pcnet_cs and zorro8390.
Then that's a bug, we have a very simple easy to implement int
On Mon, 12 Feb 2018, David Miller wrote:
> From: Finn Thain
> Date: Sun, 11 Feb 2018 22:08:43 -0500 (EST)
>
> > The lib8390 module parameter 'msg_enable' doesn't do anything useful:
> > it causes an ancient version string to be logged.
>
> Not true.
>
> You need to look at the various netif_*(
From: Finn Thain
Date: Sun, 11 Feb 2018 22:08:43 -0500 (EST)
> The lib8390 module parameter 'msg_enable' doesn't do anything useful:
> it causes an ancient version string to be logged.
Not true.
You need to look at the various netif_*() et al. message logging
interfaces, they check "p->msg_enab
The lib8390 module parameter 'msg_enable' doesn't do anything useful:
it causes an ancient version string to be logged.
Remove redundant code that logs the same string.
In ne.c and wd.c, the value of ei_local->msg_enable is used before
being assigned. Use ne_msg_enable and wd_msg_enable, respecti
