Re: [PATCH net v3 3/5] packet: only allow extra vlan len on ethernet devices

2015-11-11 Thread Willem de Bruijn
On Wed, Nov 11, 2015 at 6:07 PM, Daniel Borkmann wrote: > On 11/11/2015 11:55 PM, Willem de Bruijn wrote: >> >> On Wed, Nov 11, 2015 at 5:25 PM, Daniel Borkmann >> wrote: > > ... >>> >>> + if (!gso_type && (len > dev->mtu + reserve + extra_len) && >>> + !packet_extra_vlan_len_allo

Re: [PATCH net v3 3/5] packet: only allow extra vlan len on ethernet devices

2015-11-11 Thread Daniel Borkmann
On 11/11/2015 11:55 PM, Willem de Bruijn wrote: On Wed, Nov 11, 2015 at 5:25 PM, Daniel Borkmann wrote: ... + if (!gso_type && (len > dev->mtu + reserve + extra_len) && + !packet_extra_vlan_len_allowed(dev, skb)) { + err = -EMSGSIZE; + goto out_free;

Re: [PATCH net v3 3/5] packet: only allow extra vlan len on ethernet devices

2015-11-11 Thread Willem de Bruijn
On Wed, Nov 11, 2015 at 5:25 PM, Daniel Borkmann wrote: > Packet sockets can be used by various net devices and are not > really restricted to ARPHRD_ETHER device types. However, when > currently checking for the extra 4 bytes that can be transmitted > in VLAN case, our assumption is that we gener

[PATCH net v3 3/5] packet: only allow extra vlan len on ethernet devices

2015-11-11 Thread Daniel Borkmann
Packet sockets can be used by various net devices and are not really restricted to ARPHRD_ETHER device types. However, when currently checking for the extra 4 bytes that can be transmitted in VLAN case, our assumption is that we generally probe on ARPHRD_ETHER devices. Therefore, before looking int