On 16-02-09 03:40 AM, David Miller wrote:
From: Eric Dumazet
Date: Mon, 08 Feb 2016 14:57:40 -0800
Whole point of TLV is that it allows us to add new fields at the end of
the structures.
...
Look at iproute2, you were the one adding in 2004 code to cope with
various tcp_info sizes.
So 12
From: Eric Dumazet
Date: Mon, 08 Feb 2016 14:57:40 -0800
> Whole point of TLV is that it allows us to add new fields at the end of
> the structures.
...
> Look at iproute2, you were the one adding in 2004 code to cope with
> various tcp_info sizes.
>
> So 12 years later, you cannot say it does
On Mon, 2016-02-08 at 11:38 -0800, Stephen Hemminger wrote:
> The iproute2 command can be fixed, but adding dependency on size of response
> gets gross fast. Imagine when 4 more fields get added, this doesn't scale
> well.
Really ? I see no problem at all doing the proper tests.
>
> Also, the
On Mon, 8 Feb 2016 13:32:54 -0500
Jarod Wilson wrote:
> On Sun, Feb 07, 2016 at 12:19:28PM -0800, Eric Dumazet wrote:
> > On Sun, 2016-02-07 at 14:46 -0500, David Miller wrote:
> >
> > > > Why was this userspace ABI change allowed?
> > > > The stats structure is exposed to user space via netlink
On Sun, Feb 07, 2016 at 12:19:28PM -0800, Eric Dumazet wrote:
> On Sun, 2016-02-07 at 14:46 -0500, David Miller wrote:
>
> > > Why was this userspace ABI change allowed?
> > > The stats structure is exposed to user space via netlink
> > > and changing the size of responses will break iproute2 comm
On Sun, 2016-02-07 at 14:46 -0500, David Miller wrote:
> > Why was this userspace ABI change allowed?
> > The stats structure is exposed to user space via netlink
> > and changing the size of responses will break iproute2 commands.
I do not think it breaks anything.
iproute2 always assumed kerne
From: Stephen Hemminger
Date: Sun, 7 Feb 2016 11:37:32 -0800
> On Mon, 1 Feb 2016 18:51:05 -0500
> Jarod Wilson wrote:
>
>> --- a/include/uapi/linux/if_link.h
>> +++ b/include/uapi/linux/if_link.h
>> @@ -35,6 +35,8 @@ struct rtnl_link_stats {
>> /* for cslip etc */
>> __u32 rx_comp
On Mon, 1 Feb 2016 18:51:05 -0500
Jarod Wilson wrote:
> --- a/include/uapi/linux/if_link.h
> +++ b/include/uapi/linux/if_link.h
> @@ -35,6 +35,8 @@ struct rtnl_link_stats {
> /* for cslip etc */
> __u32 rx_compressed;
> __u32 tx_compressed;
> +
> + __u32 rx_nohandler;
This adds an rx_nohandler stat counter, along with a sysfs statistics
node, and copies the counter out via netlink as well.
CC: "David S. Miller"
CC: Eric Dumazet
CC: Jiri Pirko
CC: Daniel Borkmann
CC: Tom Herbert
CC: Jay Vosburgh
CC: Veaceslav Falico
CC: Andy Gospodarek
CC: netdev@vger.ke
