Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-17 Thread wenxu
On 6/17/2020 4:38 PM, Pablo Neira Ayuso wrote: > On Wed, Jun 17, 2020 at 11:36:19AM +0800, wenxu wrote: >> On 6/17/2020 4:38 AM, Pablo Neira Ayuso wrote: >>> On Tue, Jun 16, 2020 at 05:47:17PM +0200, Simon Horman wrote: On Tue, Jun 16, 2020 at 11:18:16PM +0800, wenxu wrote: > 在 2020/6/16

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-17 Thread Pablo Neira Ayuso
On Wed, Jun 17, 2020 at 10:42:19AM +0800, wenxu wrote: [...] > >> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c > >> b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c > >> index ef7f6bc..042c285 100644 > >> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c > >> +++ b/drivers/net/ethernet

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-17 Thread Pablo Neira Ayuso
On Wed, Jun 17, 2020 at 11:36:19AM +0800, wenxu wrote: > > On 6/17/2020 4:38 AM, Pablo Neira Ayuso wrote: > > On Tue, Jun 16, 2020 at 05:47:17PM +0200, Simon Horman wrote: > >> On Tue, Jun 16, 2020 at 11:18:16PM +0800, wenxu wrote: > >>> 在 2020/6/16 22:34, Simon Horman 写道: > On Tue, Jun 16, 2

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-16 Thread wenxu
On 6/17/2020 4:38 AM, Pablo Neira Ayuso wrote: > On Tue, Jun 16, 2020 at 05:47:17PM +0200, Simon Horman wrote: >> On Tue, Jun 16, 2020 at 11:18:16PM +0800, wenxu wrote: >>> 在 2020/6/16 22:34, Simon Horman 写道: On Tue, Jun 16, 2020 at 10:20:46PM +0800, wenxu wrote: > 在 2020/6/16 18:51, Sim

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-16 Thread wenxu
On 6/16/2020 11:47 PM, Simon Horman wrote: > On Tue, Jun 16, 2020 at 11:18:16PM +0800, wenxu wrote: >> 在 2020/6/16 22:34, Simon Horman 写道: >>> On Tue, Jun 16, 2020 at 10:20:46PM +0800, wenxu wrote: 在 2020/6/16 18:51, Simon Horman 写道: > On Tue, Jun 16, 2020 at 11:19:38AM +0800, we...@uclo

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-16 Thread wenxu
On 6/17/2020 4:13 AM, Pablo Neira Ayuso wrote: > On Tue, Jun 16, 2020 at 11:19:38AM +0800, we...@ucloud.cn wrote: >> From: wenxu >> >> In the function __flow_block_indr_cleanup, The match stataments >> this->cb_priv == cb_priv is always false, the flow_block_cb->cb_priv >> is totally different d

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-16 Thread Pablo Neira Ayuso
On Tue, Jun 16, 2020 at 05:47:17PM +0200, Simon Horman wrote: > On Tue, Jun 16, 2020 at 11:18:16PM +0800, wenxu wrote: > > > > 在 2020/6/16 22:34, Simon Horman 写道: > > > On Tue, Jun 16, 2020 at 10:20:46PM +0800, wenxu wrote: > > >> 在 2020/6/16 18:51, Simon Horman 写道: > > >>> On Tue, Jun 16, 2020 at

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-16 Thread Pablo Neira Ayuso
On Tue, Jun 16, 2020 at 11:19:38AM +0800, we...@ucloud.cn wrote: > From: wenxu > > In the function __flow_block_indr_cleanup, The match stataments > this->cb_priv == cb_priv is always false, the flow_block_cb->cb_priv > is totally different data with the flow_indr_dev->cb_priv. > > Store the rep

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-16 Thread Simon Horman
On Tue, Jun 16, 2020 at 11:18:16PM +0800, wenxu wrote: > > 在 2020/6/16 22:34, Simon Horman 写道: > > On Tue, Jun 16, 2020 at 10:20:46PM +0800, wenxu wrote: > >> 在 2020/6/16 18:51, Simon Horman 写道: > >>> On Tue, Jun 16, 2020 at 11:19:38AM +0800, we...@ucloud.cn wrote: > From: wenxu > > >>>

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-16 Thread wenxu
在 2020/6/16 22:34, Simon Horman 写道: > On Tue, Jun 16, 2020 at 10:20:46PM +0800, wenxu wrote: >> 在 2020/6/16 18:51, Simon Horman 写道: >>> On Tue, Jun 16, 2020 at 11:19:38AM +0800, we...@ucloud.cn wrote: From: wenxu In the function __flow_block_indr_cleanup, The match stataments

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-16 Thread Simon Horman
On Tue, Jun 16, 2020 at 10:20:46PM +0800, wenxu wrote: > > 在 2020/6/16 18:51, Simon Horman 写道: > > On Tue, Jun 16, 2020 at 11:19:38AM +0800, we...@ucloud.cn wrote: > >> From: wenxu > >> > >> In the function __flow_block_indr_cleanup, The match stataments > >> this->cb_priv == cb_priv is always fa

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-16 Thread wenxu
在 2020/6/16 18:51, Simon Horman 写道: > On Tue, Jun 16, 2020 at 11:19:38AM +0800, we...@ucloud.cn wrote: >> From: wenxu >> >> In the function __flow_block_indr_cleanup, The match stataments >> this->cb_priv == cb_priv is always false, the flow_block_cb->cb_priv >> is totally different data with th

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-16 Thread Simon Horman
On Tue, Jun 16, 2020 at 11:19:38AM +0800, we...@ucloud.cn wrote: > From: wenxu > > In the function __flow_block_indr_cleanup, The match stataments > this->cb_priv == cb_priv is always false, the flow_block_cb->cb_priv > is totally different data with the flow_indr_dev->cb_priv. > > Store the rep

[PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-15 Thread wenxu
From: wenxu In the function __flow_block_indr_cleanup, The match stataments this->cb_priv == cb_priv is always false, the flow_block_cb->cb_priv is totally different data with the flow_indr_dev->cb_priv. Store the representor cb_priv to the flow_block_cb->indr.cb_priv in the driver. Fixes: 1fac