Re: [PATCH net v3] net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending

2021-02-18 Thread Jason A. Donenfeld
On Thu, Feb 18, 2021 at 11:06 PM Willem de Bruijn wrote: > > On Thu, Feb 18, 2021 at 3:39 PM Jason A. Donenfeld wrote: > > > > The icmp{,v6}_send functions make all sorts of use of skb->cb, casting > > Again, if respinning, please briefly describe the specific buggy code > path. I think it's info

Re: [PATCH net v3] net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending

2021-02-18 Thread Willem de Bruijn
On Thu, Feb 18, 2021 at 3:39 PM Jason A. Donenfeld wrote: > > The icmp{,v6}_send functions make all sorts of use of skb->cb, casting Again, if respinning, please briefly describe the specific buggy code path. I think it's informative and cannot be gleaned from the fix. > it with IPCB or IP6CB, a

[PATCH net v3] net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending

2021-02-18 Thread Jason A. Donenfeld
The icmp{,v6}_send functions make all sorts of use of skb->cb, casting it with IPCB or IP6CB, assuming the skb to have come directly from the inet layer. But when the packet comes from the ndo layer, especially when forwarded, there's no telling what might be in skb->cb at that point. As a result,