Re: [PATCH net v2 2/2] vxlan: support ndo_fill_metadata_dst also for IPv6

2015-12-07 Thread Jiri Benc
On Fri, 04 Dec 2015 14:28:38 -0500 (EST), David Miller wrote: > From: Pravin Shelar > > Rather than checking IS_ENABLED(CONFIG_IPV6) three separate times, all > > code can is restructured in one #if #else block by moving the ndst > > definition to IPv6 local block. > > Agreed, you should be putti

Re: [PATCH net v2 2/2] vxlan: support ndo_fill_metadata_dst also for IPv6

2015-12-04 Thread David Miller
From: Pravin Shelar Date: Fri, 4 Dec 2015 10:49:37 -0800 > On Thu, Dec 3, 2015 at 2:41 AM, Jiri Benc wrote: >> Fill the metadata correctly even when tunneling over IPv6. Also, check that >> the provided metadata is of an address family that is supported by the >> tunnel. >> >> Signed-off-by: Jir

Re: [PATCH net v2 2/2] vxlan: support ndo_fill_metadata_dst also for IPv6

2015-12-04 Thread Pravin Shelar
On Thu, Dec 3, 2015 at 2:41 AM, Jiri Benc wrote: > Fill the metadata correctly even when tunneling over IPv6. Also, check that > the provided metadata is of an address family that is supported by the > tunnel. > > Signed-off-by: Jiri Benc > --- > v2: fixed unused variable warning when building wi

[PATCH net v2 2/2] vxlan: support ndo_fill_metadata_dst also for IPv6

2015-12-03 Thread Jiri Benc
Fill the metadata correctly even when tunneling over IPv6. Also, check that the provided metadata is of an address family that is supported by the tunnel. Signed-off-by: Jiri Benc --- v2: fixed unused variable warning when building without IPv6 --- drivers/net/vxlan.c | 26 ++