Re: [PATCH net v2 2/2] udp: only do GSO if # of segs > 1

2019-10-03 Thread David Miller
From: Josh Hunt Date: Wed, 2 Oct 2019 13:29:23 -0400 > Prior to this change an application sending <= 1MSS worth of data and > enabling UDP GSO would fail if the system had SW GSO enabled, but the > same send would succeed if HW GSO offload is enabled. In addition to this > inconsistency the err

Re: [PATCH net v2 2/2] udp: only do GSO if # of segs > 1

2019-10-02 Thread Duyck, Alexander H
On Wed, 2019-10-02 at 13:29 -0400, Josh Hunt wrote: > Prior to this change an application sending <= 1MSS worth of data and > enabling UDP GSO would fail if the system had SW GSO enabled, but the > same send would succeed if HW GSO offload is enabled. In addition to this > inconsistency the error i

Re: [PATCH net v2 2/2] udp: only do GSO if # of segs > 1

2019-10-02 Thread Willem de Bruijn
On Wed, Oct 2, 2019 at 1:29 PM Josh Hunt wrote: > > Prior to this change an application sending <= 1MSS worth of data and > enabling UDP GSO would fail if the system had SW GSO enabled, but the > same send would succeed if HW GSO offload is enabled. In addition to this > inconsistency the error in

[PATCH net v2 2/2] udp: only do GSO if # of segs > 1

2019-10-02 Thread Josh Hunt
Prior to this change an application sending <= 1MSS worth of data and enabling UDP GSO would fail if the system had SW GSO enabled, but the same send would succeed if HW GSO offload is enabled. In addition to this inconsistency the error in the SW GSO case does not get back to the application if se