Re: [PATCH net v2 2/2] tun: always set skb->dev to tun->dev

2019-01-07 Thread Stanislav Fomichev
On 01/07, Willem de Bruijn wrote: > On Mon, Jan 7, 2019 at 4:41 PM Stanislav Fomichev wrote: > > > > While debugging previous issue I noticed that commit 90e33d459407 ("tun: > > enable napi_gro_frags() for TUN/TAP driver") started conditionally > > (!frags) calling eth_type_trans(skb, tun->dev) fo

Re: [PATCH net v2 2/2] tun: always set skb->dev to tun->dev

2019-01-07 Thread Willem de Bruijn
On Mon, Jan 7, 2019 at 4:41 PM Stanislav Fomichev wrote: > > While debugging previous issue I noticed that commit 90e33d459407 ("tun: > enable napi_gro_frags() for TUN/TAP driver") started conditionally > (!frags) calling eth_type_trans(skb, tun->dev) for IFF_TAP case. Since > eth_type_trans sets

[PATCH net v2 2/2] tun: always set skb->dev to tun->dev

2019-01-07 Thread Stanislav Fomichev
While debugging previous issue I noticed that commit 90e33d459407 ("tun: enable napi_gro_frags() for TUN/TAP driver") started conditionally (!frags) calling eth_type_trans(skb, tun->dev) for IFF_TAP case. Since eth_type_trans sets skb->dev, some skbs can now have NULL skb->dev. Fix that by always s