Re: [PATCH net v2 17/21] brcmfmac: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
On Sun, 8 Nov 2020 at 02:41, Arend Van Spriel wrote: > Hi Arend, Thank you for the review! > On November 7, 2020 6:25:15 PM Taehee Yoo wrote: > > > If THIS_MODULE is not set, the module would be removed while debugfs is > > being used. > > It eventually makes kernel panic. > > Is this really a

Re: [PATCH net v2 17/21] brcmfmac: set .owner to THIS_MODULE

2020-11-07 Thread Arend Van Spriel
On November 7, 2020 6:25:15 PM Taehee Yoo wrote: If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Is this really a valid concern in the context of debugs? I tend to say it is not. Whenever I am using debugs to debug my driv

[PATCH net v2 17/21] brcmfmac: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 2f8c8e62cd50 ("brcmfmac: add "reset" debugfs entry for testing reset") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline drivers/net/wireless/broadcom/brcm80211