Re: [PATCH net v2 1/2] socket: fix option SO_TIMESTAMPING_NEW

2020-10-13 Thread Jakub Kicinski
On Mon, 12 Oct 2020 22:10:31 -0700 Deepa Dinamani wrote: > > On Mon, Oct 12, 2020 at 5:36 AM Christian Eggers wrote: > > > v2: > > > - > > > - integrated proposal from Willem de Bruijn > > > - added Reviewed-by: from Willem and Deepa > > You may add my > Acked-by: Deepa Dinamani Applied

Re: [PATCH net v2 1/2] socket: fix option SO_TIMESTAMPING_NEW

2020-10-12 Thread Deepa Dinamani
> On Mon, Oct 12, 2020 at 5:36 AM Christian Eggers wrote: > > v2: > > - > > - integrated proposal from Willem de Bruijn > > - added Reviewed-by: from Willem and Deepa You may add my Acked-by: Deepa Dinamani -Deepa

Re: [PATCH net v2 1/2] socket: fix option SO_TIMESTAMPING_NEW

2020-10-12 Thread Willem de Bruijn
On Mon, Oct 12, 2020 at 5:36 AM Christian Eggers wrote: > > The comparison of optname with SO_TIMESTAMPING_NEW is wrong way around, > so SOCK_TSTAMP_NEW will first be set and than reset again. Additionally > move it out of the test for SOF_TIMESTAMPING_RX_SOFTWARE as this seems > unrelated. > > Th

[PATCH net v2 1/2] socket: fix option SO_TIMESTAMPING_NEW

2020-10-12 Thread Christian Eggers
The comparison of optname with SO_TIMESTAMPING_NEW is wrong way around, so SOCK_TSTAMP_NEW will first be set and than reset again. Additionally move it out of the test for SOF_TIMESTAMPING_RX_SOFTWARE as this seems unrelated. This problem happens on 32 bit platforms were the libc has already switc