Re: [PATCH net v2] net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending

On Thu, Feb 18, 2021 at 9:37 PM Willem de Bruijn wrote: > > On Thu, Feb 18, 2021 at 3:25 PM Jason A. Donenfeld wrote: > > > > On Thu, Feb 18, 2021 at 9:16 PM Willem de Bruijn > > wrote: > > > > > > On Thu, Feb 18, 2021 at 12:58 PM Jason A. Donenfeld > > > wrote: > > > > > > > > On Thu, Feb 18,

Re: [PATCH net v2] net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending

On Thu, Feb 18, 2021 at 3:25 PM Jason A. Donenfeld wrote: > > On Thu, Feb 18, 2021 at 9:16 PM Willem de Bruijn > wrote: > > > > On Thu, Feb 18, 2021 at 12:58 PM Jason A. Donenfeld wrote: > > > > > > On Thu, Feb 18, 2021 at 5:34 PM Willem de Bruijn > > > wrote: > > > > Thanks for respinning. > >

Re: [PATCH net v2] net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending

On Thu, Feb 18, 2021 at 9:16 PM Willem de Bruijn wrote: > > On Thu, Feb 18, 2021 at 12:58 PM Jason A. Donenfeld wrote: > > > > On Thu, Feb 18, 2021 at 5:34 PM Willem de Bruijn > > wrote: > > > Thanks for respinning. > > > > > > Making ipv4 and ipv6 more aligned is a good goal, but more for > > >

Re: [PATCH net v2] net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending

On Thu, Feb 18, 2021 at 12:58 PM Jason A. Donenfeld wrote: > > On Thu, Feb 18, 2021 at 5:34 PM Willem de Bruijn > wrote: > > Thanks for respinning. > > > > Making ipv4 and ipv6 more aligned is a good goal, but more for > > net-next than bug fixes that need to be backported to many stable > > bran

Re: [PATCH net v2] net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending

On Thu, Feb 18, 2021 at 5:34 PM Willem de Bruijn wrote: > Thanks for respinning. > > Making ipv4 and ipv6 more aligned is a good goal, but more for > net-next than bug fixes that need to be backported to many stable > branches. > > Beyond that, I'm not sure this fixes additional cases vs the previ

Re: [PATCH net v2] net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending

On Thu, Feb 18, 2021 at 11:08 AM Jason A. Donenfeld wrote: > > The icmp{,v6}_send functions make all sorts of use of skb->cb, casting > it with IPCB or IP6CB, assuming the skb to have come directly from the > inet layer. But when the packet comes from the ndo layer, especially > when forwarded, th

[PATCH net v2] net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending

The icmp{,v6}_send functions make all sorts of use of skb->cb, casting it with IPCB or IP6CB, assuming the skb to have come directly from the inet layer. But when the packet comes from the ndo layer, especially when forwarded, there's no telling what might be in skb->cb at that point. As a result,