Re: [PATCH net v2] mld, igmp: Fix reserved tailroom calculation

2016-03-03 Thread David Miller
From: Benjamin Poirier Date: Mon, 29 Feb 2016 15:03:33 -0800 > The current reserved_tailroom calculation fails to take hlen and tlen into > account. ... > Fixes: 4c672e4b ("ipv6: mld: fix add_grhead skb_over_panic for devs with > large MTUs") > Signed-off-by: Benjamin Poirier Applied and queu

Re: [PATCH net v2] mld, igmp: Fix reserved tailroom calculation

2016-03-01 Thread Hannes Frederic Sowa
On 01.03.2016 11:18, Daniel Borkmann wrote: On 03/01/2016 12:03 AM, Benjamin Poirier wrote: [...] Notes: Changes v1->v2 As suggested by Hannes, move the code to an inline helper and express it using "if" rather than "min". The code is correct, thanks! Therefore: Acked-by: Dani

Re: [PATCH net v2] mld, igmp: Fix reserved tailroom calculation

2016-03-01 Thread Daniel Borkmann
On 03/01/2016 12:03 AM, Benjamin Poirier wrote: [...] Notes: Changes v1->v2 As suggested by Hannes, move the code to an inline helper and express it using "if" rather than "min". The code is correct, thanks! Therefore: Acked-by: Daniel Borkmann However, I actually think that

Re: [PATCH net v2] mld, igmp: Fix reserved tailroom calculation

2016-03-01 Thread Hannes Frederic Sowa
On 01.03.2016 00:03, Benjamin Poirier wrote: The current reserved_tailroom calculation fails to take hlen and tlen into account. skb: [__hlen__|__data|__tlen___|__extra__] ^ ^ headskb_end_offset

[PATCH net v2] mld, igmp: Fix reserved tailroom calculation

2016-02-29 Thread Benjamin Poirier
The current reserved_tailroom calculation fails to take hlen and tlen into account. skb: [__hlen__|__data|__tlen___|__extra__] ^ ^ headskb_end_offset In this representation, hlen + data + tlen is