Re: [PATCH net v2] ipv6: enforce egress device match in per table nexthop lookups

2016-06-27 Thread David Miller
From: Paolo Abeni Date: Thu, 23 Jun 2016 15:25:09 +0200 > with the commit 8c14586fc320 ("net: ipv6: Use passed in table for > nexthop lookups"), net hop lookup is first performed on route creation > in the passed-in table. > However device match is not enforced in table lookup, so the found > rou

Re: [PATCH net v2] ipv6: enforce egress device match in per table nexthop lookups

2016-06-23 Thread David Ahern
On 6/23/16 8:39 AM, Paolo Abeni wrote: On Thu, 2016-06-23 at 08:29 -0600, David Ahern wrote: On 6/23/16 8:20 AM, David Ahern wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 969913d..520b788 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1782,7 +1782,7 @@ static struct rt

Re: [PATCH net v2] ipv6: enforce egress device match in per table nexthop lookups

2016-06-23 Thread Paolo Abeni
On Thu, 2016-06-23 at 08:29 -0600, David Ahern wrote: > On 6/23/16 8:20 AM, David Ahern wrote: > >> diff --git a/net/ipv6/route.c b/net/ipv6/route.c > >> index 969913d..520b788 100644 > >> --- a/net/ipv6/route.c > >> +++ b/net/ipv6/route.c > >> @@ -1782,7 +1782,7 @@ static struct rt6_info > >> *ip6

Re: [PATCH net v2] ipv6: enforce egress device match in per table nexthop lookups

2016-06-23 Thread David Ahern
On 6/23/16 8:20 AM, David Ahern wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 969913d..520b788 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1782,7 +1782,7 @@ static struct rt6_info *ip6_nh_lookup_table(struct net *net, }; struct fib6_table *table; struct

Re: [PATCH net v2] ipv6: enforce egress device match in per table nexthop lookups

2016-06-23 Thread David Ahern
On 6/23/16 7:25 AM, Paolo Abeni wrote: with the commit 8c14586fc320 ("net: ipv6: Use passed in table for nexthop lookups"), net hop lookup is first performed on route creation in the passed-in table. However device match is not enforced in table lookup, so the found route can be later discarded d

[PATCH net v2] ipv6: enforce egress device match in per table nexthop lookups

2016-06-23 Thread Paolo Abeni
with the commit 8c14586fc320 ("net: ipv6: Use passed in table for nexthop lookups"), net hop lookup is first performed on route creation in the passed-in table. However device match is not enforced in table lookup, so the found route can be later discarded due to egress device mismatch and no globa