Re: [PATCH net v2] hinic: fix a bug of ndo_stop

2020-05-10 Thread luobin (L)
Will fix. Thanks. On 2020/5/10 6:37, Jakub Kicinski wrote: On Fri, 8 May 2020 20:19:33 + Luo bin wrote: if some function in ndo_stop interface returns failure because of hardware fault, must go on excuting rest steps rather than return failure directly, otherwise will cause memory leak.And

Re: [PATCH net v2] hinic: fix a bug of ndo_stop

2020-05-09 Thread Jakub Kicinski
On Fri, 8 May 2020 20:19:33 + Luo bin wrote: > if some function in ndo_stop interface returns failure because of > hardware fault, must go on excuting rest steps rather than return > failure directly, otherwise will cause memory leak.And bump the > timeout for SET_FUNC_STATE to ensure that cmd

[PATCH net v2] hinic: fix a bug of ndo_stop

2020-05-08 Thread Luo bin
if some function in ndo_stop interface returns failure because of hardware fault, must go on excuting rest steps rather than return failure directly, otherwise will cause memory leak.And bump the timeout for SET_FUNC_STATE to ensure that cmd won't return failure when hw is busy. Otherwise hw may st