Re: [PATCH net v2] esp: select CRYPTO_SEQIV when useful

2020-06-07 Thread Herbert Xu
On Fri, Jun 05, 2020 at 11:00:23AM -0700, Eric Biggers wrote: > > Oops, this doesn't actually work: > > scripts/kconfig/conf --olddefconfig Kconfig > crypto/Kconfig:1799:error: recursive dependency detected! > crypto/Kconfig:1799: symbol CRYPTO_DRBG_MENU is selected by > CRYPTO_RNG_DEFAULT > cr

Re: [PATCH net v2] esp: select CRYPTO_SEQIV when useful

2020-06-06 Thread Steffen Klassert
On Fri, Jun 05, 2020 at 11:00:23AM -0700, Eric Biggers wrote: > On Fri, Jun 05, 2020 at 10:39:31AM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig > > index 23ba5045e3d3..6520b30883cf 100644 > > --- a/net/ipv4/Kconfig > > +++ b/net/ipv4/K

Re: [PATCH net v2] esp: select CRYPTO_SEQIV when useful

2020-06-05 Thread Eric Biggers
On Fri, Jun 05, 2020 at 10:39:31AM -0700, Eric Biggers wrote: > From: Eric Biggers > > CRYPTO_CTR no longer selects CRYPTO_SEQIV, which breaks IPsec for users > who need any of the algorithms that use seqiv. These users now would > need to explicitly enable CRYPTO_SEQIV. > > There doesn't seem

[PATCH net v2] esp: select CRYPTO_SEQIV when useful

2020-06-05 Thread Eric Biggers
From: Eric Biggers CRYPTO_CTR no longer selects CRYPTO_SEQIV, which breaks IPsec for users who need any of the algorithms that use seqiv. These users now would need to explicitly enable CRYPTO_SEQIV. There doesn't seem to be a clear rule on what algorithms the IPsec options (INET_ESP and INET6_