Re: [PATCH net v2] cxgb4/chcr: Enable ktls settings at run time

2020-05-28 Thread Jakub Kicinski
On Thu, 28 May 2020 09:36:43 +0530 rohit maheshwari wrote: > CHCR driver is a ULD driver, and if user requests to remove chcr alone, > this cleanup will be done. This is why I am taking module refcount until > tls offload flag is set, or any single tls offload connection exists.  > So, now, > when

Re: [PATCH net v2] cxgb4/chcr: Enable ktls settings at run time

2020-05-27 Thread rohit maheshwari
On 28/05/20 2:34 AM, Jakub Kicinski wrote: On Wed, 27 May 2020 10:02:42 +0530 rohit maheshwari wrote: On 27/05/20 4:12 AM, Jakub Kicinski wrote: On Tue, 26 May 2020 19:36:34 +0530 Rohit Maheshwari wrote: Current design enables ktls setting from start, which is not efficient. Now the feature

Re: [PATCH net v2] cxgb4/chcr: Enable ktls settings at run time

2020-05-27 Thread Jakub Kicinski
On Wed, 27 May 2020 10:02:42 +0530 rohit maheshwari wrote: > On 27/05/20 4:12 AM, Jakub Kicinski wrote: > > On Tue, 26 May 2020 19:36:34 +0530 Rohit Maheshwari wrote: > >> Current design enables ktls setting from start, which is not > >> efficient. Now the feature will be enabled when user demand

Re: [PATCH net v2] cxgb4/chcr: Enable ktls settings at run time

2020-05-26 Thread rohit maheshwari
On 27/05/20 4:12 AM, Jakub Kicinski wrote: On Tue, 26 May 2020 19:36:34 +0530 Rohit Maheshwari wrote: Current design enables ktls setting from start, which is not efficient. Now the feature will be enabled when user demands TLS offload on any interface. v1->v2: - taking ULD module refcount ti

Re: [PATCH net v2] cxgb4/chcr: Enable ktls settings at run time

2020-05-26 Thread Jakub Kicinski
On Tue, 26 May 2020 19:36:34 +0530 Rohit Maheshwari wrote: > Current design enables ktls setting from start, which is not > efficient. Now the feature will be enabled when user demands > TLS offload on any interface. > > v1->v2: > - taking ULD module refcount till any single connection exists. > -

[PATCH net v2] cxgb4/chcr: Enable ktls settings at run time

2020-05-26 Thread Rohit Maheshwari
Current design enables ktls setting from start, which is not efficient. Now the feature will be enabled when user demands TLS offload on any interface. v1->v2: - taking ULD module refcount till any single connection exists. - taking rtnl_lock() before clearing tls_devops. Signed-off-by: Rohit Mah