Re: [PATCH net v2] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 07:45:09 -0400 Michael S. Tsirkin wrote: > On Mon, Oct 19, 2020 at 12:15:00PM -0700, Jakub Kicinski wrote: > > On Mon, 19 Oct 2020 13:32:12 -0400 Michael S. Tsirkin wrote: > > > This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. > > > > > > When the device does not

Re: [PATCH net v2] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-20 Thread Michael S. Tsirkin
On Tue, Oct 20, 2020 at 02:13:06PM +0800, Jason Wang wrote: > > On 2020/10/20 上午1:32, Michael S. Tsirkin wrote: > > This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. > > > > When the device does not have a control vq (e.g. when using a > > version of QEMU based on upstream v0.10 or ol

Re: [PATCH net v2] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-20 Thread Michael S. Tsirkin
On Mon, Oct 19, 2020 at 12:15:00PM -0700, Jakub Kicinski wrote: > On Mon, 19 Oct 2020 13:32:12 -0400 Michael S. Tsirkin wrote: > > This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. > > > > When the device does not have a control vq (e.g. when using a > > version of QEMU based on upstre

Re: [PATCH net v2] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-19 Thread Jason Wang
On 2020/10/20 上午1:32, Michael S. Tsirkin wrote: This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. When the device does not have a control vq (e.g. when using a version of QEMU based on upstream v0.10 or older, or when specifying ctrl_vq=off,ctrl_rx=off,ctrl_vlan=off,ctrl_rx_extra=o

Re: [PATCH net v2] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-19 Thread Jakub Kicinski
On Mon, 19 Oct 2020 13:32:12 -0400 Michael S. Tsirkin wrote: > This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. > > When the device does not have a control vq (e.g. when using a > version of QEMU based on upstream v0.10 or older, or when specifying > ctrl_vq=off,ctrl_rx=off,ctrl_vlan=