Re: [PATCH net v1 2/2] net: dsa: microchip: improve port count comments

2020-12-07 Thread Jakub Kicinski
On Tue, 8 Dec 2020 00:31:16 +0100 Andrew Lunn wrote: > On Sat, Dec 05, 2020 at 10:28:14AM -0500, Sven Van Asbroeck wrote: > > From: Sven Van Asbroeck > > > > Port counts in microchip dsa drivers can be quite confusing: > > on the ksz8795, ksz_chip_data->port_cnt excludes the cpu port, > > yet on

Re: [PATCH net v1 2/2] net: dsa: microchip: improve port count comments

2020-12-07 Thread Andrew Lunn
On Sat, Dec 05, 2020 at 10:28:14AM -0500, Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > Port counts in microchip dsa drivers can be quite confusing: > on the ksz8795, ksz_chip_data->port_cnt excludes the cpu port, > yet on the ksz9477, it includes the cpu port. > > Add comments to docum

[PATCH net v1 2/2] net: dsa: microchip: improve port count comments

2020-12-05 Thread Sven Van Asbroeck
From: Sven Van Asbroeck Port counts in microchip dsa drivers can be quite confusing: on the ksz8795, ksz_chip_data->port_cnt excludes the cpu port, yet on the ksz9477, it includes the cpu port. Add comments to document this situation explicitly. Fixes: 912aae27c6af ("net: dsa: microchip: really