Re: [PATCH net v1 1/2] net: dsa: microchip: fix devicetree parsing of cpu node

2020-12-08 Thread Sven Van Asbroeck
On Tue, Dec 8, 2020 at 11:52 AM Jakub Kicinski wrote: > > What I was talking about in the email yesterday was 0x8794 support > in ksz8795.c. Is the cpu port configuration going to work there? > Isn't the CPU port always port 5 (index 4)? Understood. You expressed concern that .cpu_ports = 0x10 ev

Re: [PATCH net v1 1/2] net: dsa: microchip: fix devicetree parsing of cpu node

2020-12-08 Thread Jakub Kicinski
On Tue, 8 Dec 2020 10:33:28 -0500 Sven Van Asbroeck wrote: > Andrew, Jakub, > > On Sat, Dec 5, 2020 at 10:28 AM Sven Van Asbroeck wrote: > > > > From: Sven Van Asbroeck > > > > On the ksz8795, if the devicetree contains a cpu node, > > devicetree parsing fails and the whole driver errors out. >

Re: [PATCH net v1 1/2] net: dsa: microchip: fix devicetree parsing of cpu node

2020-12-08 Thread Sven Van Asbroeck
Andrew, Jakub, On Sat, Dec 5, 2020 at 10:28 AM Sven Van Asbroeck wrote: > > From: Sven Van Asbroeck > > On the ksz8795, if the devicetree contains a cpu node, > devicetree parsing fails and the whole driver errors out. > > Fix the devicetree parsing code by making it use the > correct number of

[PATCH net v1 1/2] net: dsa: microchip: fix devicetree parsing of cpu node

2020-12-05 Thread Sven Van Asbroeck
From: Sven Van Asbroeck On the ksz8795, if the devicetree contains a cpu node, devicetree parsing fails and the whole driver errors out. Fix the devicetree parsing code by making it use the correct number of ports. Fixes: 912aae27c6af ("net: dsa: microchip: really look for phy-mode in port nod