Re: [PATCH net V4 1/2] net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs

2019-10-16 Thread Marek Vasut
On 10/16/19 7:46 PM, David Miller wrote: > From: Marek Vasut > Date: Wed, 16 Oct 2019 15:39:18 +0200 > >> Maybe next time we can do these exercises on patches which are not >> bugfixes for real issues? > > No, we should put changes into the tree which are correctly formed. > > If you're not inte

Re: [PATCH net V4 1/2] net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs

2019-10-16 Thread David Miller
From: Marek Vasut Date: Wed, 16 Oct 2019 15:39:18 +0200 > Maybe next time we can do these exercises on patches which are not > bugfixes for real issues? No, we should put changes into the tree which are correctly formed. If you're not interested in learning how to submit changes properly, we am

Re: [PATCH net V4 1/2] net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs

2019-10-16 Thread Marek Vasut
On 10/16/19 2:42 AM, David Miller wrote: > From: Marek Vasut > Date: Sun, 13 Oct 2019 23:24:03 +0200 > >> Signed-off-by: Marek Vasut >> Fixes: 9d162ed69f51 ("net: phy: micrel: add support for KSZ8795") > > I'm sorry to be strict, but as Heiner said the Fixes: tag needs to be > the first tag. >

Re: [PATCH net V4 1/2] net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs

2019-10-15 Thread David Miller
From: Marek Vasut Date: Sun, 13 Oct 2019 23:24:03 +0200 > Signed-off-by: Marek Vasut > Fixes: 9d162ed69f51 ("net: phy: micrel: add support for KSZ8795") I'm sorry to be strict, but as Heiner said the Fixes: tag needs to be the first tag. I'm pushing this back to you so that you can learn how t

Re: [PATCH net V4 1/2] net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs

2019-10-14 Thread Andrew Lunn
On Sun, Oct 13, 2019 at 11:24:03PM +0200, Marek Vasut wrote: > The KSZ8051 PHY and the KSZ8794/KSZ8795/KSZ8765 switch share exactly the > same PHY ID. Since KSZ8051 is higher in the ksphy_driver[] list of PHYs > in the micrel PHY driver, it is used even with the KSZ87xx switch. This > is wrong, sin

[PATCH net V4 1/2] net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs

2019-10-13 Thread Marek Vasut
The KSZ8051 PHY and the KSZ8794/KSZ8795/KSZ8765 switch share exactly the same PHY ID. Since KSZ8051 is higher in the ksphy_driver[] list of PHYs in the micrel PHY driver, it is used even with the KSZ87xx switch. This is wrong, since the KSZ8051 configures registers of the PHY which are not present