RE: [PATCH net V2 1/1] net: phy: fix invalid phy id when probe using C22

2021-03-22 Thread Wong, Vee Khee
On Fri, Mar 19, 2021 at 04:56PM +0800, Russell King - ARM Linux admin wrote: > On Fri, Mar 19, 2021 at 08:40:45AM +0100, Heiner Kallweit wrote: >> Is there a specific reason why c22 is probed first? Reversing the order >> would solve the issue we speak about here. >> c45-probing of c22-only PHY's s

Re: [PATCH net V2 1/1] net: phy: fix invalid phy id when probe using C22

2021-03-19 Thread Russell King - ARM Linux admin
On Fri, Mar 19, 2021 at 08:40:45AM +0100, Heiner Kallweit wrote: > Is there a specific reason why c22 is probed first? Reversing the order > would solve the issue we speak about here. > c45-probing of c22-only PHY's shouldn't return false positives > (at least at a first glance). That would likely

Re: [PATCH net V2 1/1] net: phy: fix invalid phy id when probe using C22

2021-03-19 Thread Heiner Kallweit
On 18.03.2021 10:09, Wong Vee Khee wrote: > When using Clause-22 to probe for PHY devices such as the Marvell > 88E2110, PHY ID with value 0 is read from the MII PHYID registers > which caused the PHY framework failed to attach the Marvell PHY > driver. > > Fixed this by adding a check of PHY ID e

Re: [PATCH net V2 1/1] net: phy: fix invalid phy id when probe using C22

2021-03-18 Thread Florian Fainelli
On 3/18/2021 11:14 AM, Greg KH wrote: > On Thu, Mar 18, 2021 at 09:02:22AM -0700, Florian Fainelli wrote: >> >> >> On 3/18/2021 6:25 AM, Heiner Kallweit wrote: >>> On 18.03.2021 10:09, Wong Vee Khee wrote: When using Clause-22 to probe for PHY devices such as the Marvell 88E2110, PHY I

Re: [PATCH net V2 1/1] net: phy: fix invalid phy id when probe using C22

2021-03-18 Thread Greg KH
On Thu, Mar 18, 2021 at 09:02:22AM -0700, Florian Fainelli wrote: > > > On 3/18/2021 6:25 AM, Heiner Kallweit wrote: > > On 18.03.2021 10:09, Wong Vee Khee wrote: > >> When using Clause-22 to probe for PHY devices such as the Marvell > >> 88E2110, PHY ID with value 0 is read from the MII PHYID re

Re: [PATCH net V2 1/1] net: phy: fix invalid phy id when probe using C22

2021-03-18 Thread Heiner Kallweit
On 18.03.2021 17:02, Florian Fainelli wrote: > > > On 3/18/2021 6:25 AM, Heiner Kallweit wrote: >> On 18.03.2021 10:09, Wong Vee Khee wrote: >>> When using Clause-22 to probe for PHY devices such as the Marvell >>> 88E2110, PHY ID with value 0 is read from the MII PHYID registers >>> which caused

Re: [PATCH net V2 1/1] net: phy: fix invalid phy id when probe using C22

2021-03-18 Thread Russell King - ARM Linux admin
On Thu, Mar 18, 2021 at 09:02:22AM -0700, Florian Fainelli wrote: > On 3/18/2021 6:25 AM, Heiner Kallweit wrote: > > On 18.03.2021 10:09, Wong Vee Khee wrote: > >> When using Clause-22 to probe for PHY devices such as the Marvell > >> 88E2110, PHY ID with value 0 is read from the MII PHYID register

Re: [PATCH net V2 1/1] net: phy: fix invalid phy id when probe using C22

2021-03-18 Thread Florian Fainelli
On 3/18/2021 6:25 AM, Heiner Kallweit wrote: > On 18.03.2021 10:09, Wong Vee Khee wrote: >> When using Clause-22 to probe for PHY devices such as the Marvell >> 88E2110, PHY ID with value 0 is read from the MII PHYID registers >> which caused the PHY framework failed to attach the Marvell PHY >>

Re: [PATCH net V2 1/1] net: phy: fix invalid phy id when probe using C22

2021-03-18 Thread Heiner Kallweit
On 18.03.2021 10:09, Wong Vee Khee wrote: > When using Clause-22 to probe for PHY devices such as the Marvell > 88E2110, PHY ID with value 0 is read from the MII PHYID registers > which caused the PHY framework failed to attach the Marvell PHY > driver. > > Fixed this by adding a check of PHY ID e

[PATCH net V2 1/1] net: phy: fix invalid phy id when probe using C22

2021-03-18 Thread Wong Vee Khee
When using Clause-22 to probe for PHY devices such as the Marvell 88E2110, PHY ID with value 0 is read from the MII PHYID registers which caused the PHY framework failed to attach the Marvell PHY driver. Fixed this by adding a check of PHY ID equals to all zeroes. Fixes: ee951005e95e ("net: phy: