Re: [PATCH net V2 1/1] net/smc: coordinate wait queues for nonblocking connect

2018-06-21 Thread Cong Wang
On Thu, Jun 21, 2018 at 7:23 AM, Ursula Braun wrote: > @@ -605,6 +606,13 @@ static int smc_connect(struct socket *sock, struct > sockaddr *addr, > > smc_copy_sock_settings_to_clc(smc); > tcp_sk(smc->clcsock->sk)->syn_smc = 1; > + if (flags & O_NONBLOCK) { > + r

[PATCH net V2 1/1] net/smc: coordinate wait queues for nonblocking connect

2018-06-21 Thread Ursula Braun
The recent poll change may lead to stalls for non-blocking connecting SMC sockets, since sock_poll_wait is no longer performed on the internal CLC socket, but on the outer SMC socket. kernel_connect() on the internal CLC socket returns with -EINPROGRESS, but the wake up logic does not work in all