Re: [PATCH net 5/7] virtio_net: Don't process redirected XDP frames when XDP is disabled

2019-01-17 Thread Toshiaki Makita
On 2019/01/18 12:52, Jason Wang wrote: > On 2019/1/18 上午9:56, Toshiaki Makita wrote: >> On 2019/01/17 22:05, Jason Wang wrote: >>> On 2019/1/17 下午8:53, Jason Wang wrote: On 2019/1/17 下午7:20, Toshiaki Makita wrote: > Commit 8dcc5b0ab0ec ("virtio_net: fix ndo_xdp_xmit crash towards > dev

Re: [PATCH net 5/7] virtio_net: Don't process redirected XDP frames when XDP is disabled

2019-01-17 Thread Jason Wang
On 2019/1/18 上午9:56, Toshiaki Makita wrote: On 2019/01/17 22:05, Jason Wang wrote: On 2019/1/17 下午8:53, Jason Wang wrote: On 2019/1/17 下午7:20, Toshiaki Makita wrote: Commit 8dcc5b0ab0ec ("virtio_net: fix ndo_xdp_xmit crash towards dev not ready for XDP") tried to avoid access to unexpected s

Re: [PATCH net 5/7] virtio_net: Don't process redirected XDP frames when XDP is disabled

2019-01-17 Thread Toshiaki Makita
On 2019/01/17 22:05, Jason Wang wrote: > On 2019/1/17 下午8:53, Jason Wang wrote: >> On 2019/1/17 下午7:20, Toshiaki Makita wrote: >>> Commit 8dcc5b0ab0ec ("virtio_net: fix ndo_xdp_xmit crash towards dev not >>> ready for XDP") tried to avoid access to unexpected sq while XDP is >>> disabled, but was n

Re: [PATCH net 5/7] virtio_net: Don't process redirected XDP frames when XDP is disabled

2019-01-17 Thread Jason Wang
On 2019/1/17 下午8:53, Jason Wang wrote: On 2019/1/17 下午7:20, Toshiaki Makita wrote: Commit 8dcc5b0ab0ec ("virtio_net: fix ndo_xdp_xmit crash towards dev not ready for XDP") tried to avoid access to unexpected sq while XDP is disabled, but was not complete. There was a small window which cause

Re: [PATCH net 5/7] virtio_net: Don't process redirected XDP frames when XDP is disabled

2019-01-17 Thread Jason Wang
On 2019/1/17 下午7:20, Toshiaki Makita wrote: Commit 8dcc5b0ab0ec ("virtio_net: fix ndo_xdp_xmit crash towards dev not ready for XDP") tried to avoid access to unexpected sq while XDP is disabled, but was not complete. There was a small window which causes out of bounds sq access in virtnet_xdp_

[PATCH net 5/7] virtio_net: Don't process redirected XDP frames when XDP is disabled

2019-01-17 Thread Toshiaki Makita
Commit 8dcc5b0ab0ec ("virtio_net: fix ndo_xdp_xmit crash towards dev not ready for XDP") tried to avoid access to unexpected sq while XDP is disabled, but was not complete. There was a small window which causes out of bounds sq access in virtnet_xdp_xmit() while disabling XDP. An example case of