Re: [PATCH net 2/5] bnxt_en: Fix devlink NVRAM related byte order related issues.

2019-10-21 Thread Michael Chan
On Mon, Oct 21, 2019 at 9:14 PM Jakub Kicinski wrote: > > On Mon, 21 Oct 2019 01:34:26 -0400, Michael Chan wrote: > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > > b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > > index 68f74f5..bd4b9f3 100644 > > --- a/drivers/net/ethe

Re: [PATCH net 2/5] bnxt_en: Fix devlink NVRAM related byte order related issues.

2019-10-21 Thread Jakub Kicinski
On Mon, 21 Oct 2019 01:34:26 -0400, Michael Chan wrote: > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > index 68f74f5..bd4b9f3 100644 > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > +++ b/drivers/net/ethernet/broa

[PATCH net 2/5] bnxt_en: Fix devlink NVRAM related byte order related issues.

2019-10-20 Thread Michael Chan
The current code does not do endian swapping between the devlink parameter and the internal NVRAM representation. Define a union to represent the little endian NVRAM data and add 2 helper functions to copy to and from the NVRAM data with the proper byte swapping. Fixes: 782a624d00fa ("bnxt_en: Ad